Merge pull request #90 from PowerShell/dev

Release of version 4.3.0.0 of DFSDsc
dsccommunity · Feb 20, 2019 · 9d16431 · 9d16431
2 parents 48a75a6 + dd87532
commit 9d16431
Show file tree

Hide file tree

Showing 5 changed files with 72 additions and 32 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 ## Unreleased
 
+## 4.3.0.0
+
+- Fixes PSSA style violation issues resulting - fixes [Issue #84](https://github.com/PowerShell/DfsDsc/issues/84).
+- Added 'DscResourcesToExport' to manifest to improve information in
+  PowerShell Gallery - fixes [Issue #86](https://github.com/PowerShell/DfsDsc/issues/86).
+- Set FunctionsToExport, CmdletsToExport, VariablesToExport, AliasesToExport
+  to empty list in manifest to meet best practice.
+- Explicitly removed extra hidden files from release package
+
 ## 4.2.0.0
 
 - Add support for modifying staging quota size in

diff --git a/DFSDsc.psd1 b/DFSDsc.psd1
@@ -1,6 +1,6 @@
 @{
     # Version number of this module.
-    moduleVersion = '4.2.0.0'
+    moduleVersion = '4.3.0.0'
 
     # ID used to uniquely identify this module
     GUID = '3bcb9c66-ea0b-4675-bd46-c390a382c388'
@@ -29,17 +29,34 @@
     # Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
     # NestedModules = @()
 
-    # Functions to export from this module
-    FunctionsToExport = '*'
+    # Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
+    FunctionsToExport = @()
 
-    # Cmdlets to export from this module
-    CmdletsToExport = '*'
+    # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
+    CmdletsToExport = @()
+
+    # Variables to export from this module
+    VariablesToExport = @()
+
+    # Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
+    AliasesToExport = @()
+
+    # DSC resources to export from this module
+    DscResourcesToExport = @(
+        'DFSNamespaceFolder',
+        'DFSNamespaceRoot',
+        'DFSNamespaceServerConfiguration',
+        'DFSReplicationGroup',
+        'DFSReplicationGroupConnection',
+        'DFSReplicationGroupFolder',
+        'DFSReplicationGroupMembership'
+        )
 
     # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
     PrivateData = @{
         PSData = @{
             # Tags applied to this module. These help with module discovery in online galleries.
-            Tags = @( 'DSC','DesiredStateConfiguration','DSCResourceKit','DSCResource','DFS','DistributedFileSystem' )
+            Tags = @( 'DSC', 'DesiredStateConfiguration', 'DSCResourceKit', 'DSCResource', 'DFS', 'DistributedFileSystem' )
 
             # A URL to the license for this module.
             LicenseUri = 'https://github.com/PowerShell/DFSDsc/blob/master/LICENSE'
@@ -48,16 +65,12 @@
             ProjectUri = 'https://github.com/PowerShell/DFSDsc'
 
             # ReleaseNotes of this module
-        ReleaseNotes = '- Add support for modifying staging quota size in
-  MSFT_DFSReplicationGroupMembership - fixes [Issue 77](https://github.com/PowerShell/DfsDsc/issues/77).
-- Refactored module folder structure to move resource to root folder of
-  repository and remove test harness - fixes [Issue 74](https://github.com/PowerShell/DfsDsc/issues/74).
-- Updated Examples to support deployment to PowerShell Gallery scripts.
-- Remove exclusion of all tags in appveyor.yml, so all common tests can be run
-  if opt-in.
-- Added .VSCode settings for applying DSC PSSA rules - fixes [Issue 75](https://github.com/PowerShell/DfsDsc/issues/75).
-- Updated LICENSE file to match the Microsoft Open Source Team
-  standard - fixes [Issue 79](https://github.com/PowerShell/DFSDsc/issues/79)
+        ReleaseNotes = '- Fixes PSSA style violation issues resulting - fixes [Issue 84](https://github.com/PowerShell/DfsDsc/issues/84).
+- Added "DscResourcesToExport" to manifest to improve information in
+  PowerShell Gallery - fixes [Issue 86](https://github.com/PowerShell/DfsDsc/issues/86).
+- Set FunctionsToExport, CmdletsToExport, VariablesToExport, AliasesToExport
+  to empty list in manifest to meet best practice.
+- Explicitly removed extra hidden files from release package
 
 '
         } # End of PSData hashtable
@@ -67,3 +80,5 @@
 
 
 
+
+
diff --git a/DSCResources/MSFT_DFSNamespaceFolder/MSFT_DFSNamespaceFolder.psm1 b/DSCResources/MSFT_DFSNamespaceFolder/MSFT_DFSNamespaceFolder.psm1
@@ -488,7 +488,8 @@ function Test-TargetResource
 
             # Check the Namespace parameters
             if (($Description) `
-                -and ($folder.Description -ne $Description)) {
+                -and ($folder.Description -ne $Description))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceFolderParameterNeedsUpdateMessage) `
@@ -498,7 +499,8 @@ function Test-TargetResource
             }
 
             if (($TimeToLiveSec) `
-                -and ($folder.TimeToLiveSec -ne $TimeToLiveSec)) {
+                -and ($folder.TimeToLiveSec -ne $TimeToLiveSec))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceFolderParameterNeedsUpdateMessage) `
@@ -508,7 +510,8 @@ function Test-TargetResource
             }
 
             if (($null -ne $EnableInsiteReferrals) `
-                -and (($folder.Flags -contains 'Insite Referrals') -ne $EnableInsiteReferrals)) {
+                -and (($folder.Flags -contains 'Insite Referrals') -ne $EnableInsiteReferrals))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceFolderParameterNeedsUpdateMessage) `
@@ -518,7 +521,8 @@ function Test-TargetResource
             }
 
             if (($null -ne $EnableTargetFailback) `
-                -and (($folder.Flags -contains 'Target Failback') -ne $EnableTargetFailback)) {
+                -and (($folder.Flags -contains 'Target Failback') -ne $EnableTargetFailback))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceFolderParameterNeedsUpdateMessage) `
@@ -534,7 +538,8 @@ function Test-TargetResource
             if ($targetFolder)
             {
                 if (($ReferralPriorityClass) `
-                    -and ($targetFolder.ReferralPriorityClass -ne $ReferralPriorityClass)) {
+                    -and ($targetFolder.ReferralPriorityClass -ne $ReferralPriorityClass))
+                {
                     Write-Verbose -Message ( @(
                         "$($MyInvocation.MyCommand): "
                         $($LocalizedData.NamespaceFolderTargetParameterNeedsUpdateMessage) `
@@ -544,7 +549,8 @@ function Test-TargetResource
                 }
 
                 if (($ReferralPriorityRank) `
-                    -and ($targetFolder.ReferralPriorityRank -ne $ReferralPriorityRank)) {
+                    -and ($targetFolder.ReferralPriorityRank -ne $ReferralPriorityRank))
+                {
                     Write-Verbose -Message ( @(
                         "$($MyInvocation.MyCommand): "
                         $($LocalizedData.NamespaceFolderTargetParameterNeedsUpdateMessage) `

diff --git a/DSCResources/MSFT_DFSNamespaceRoot/MSFT_DFSNamespaceRoot.psm1 b/DSCResources/MSFT_DFSNamespaceRoot/MSFT_DFSNamespaceRoot.psm1
@@ -596,7 +596,8 @@ function Test-TargetResource
 
             # Check the Namespace parameters
             if (($Description) `
-                -and ($root.Description -ne $Description)) {
+                -and ($root.Description -ne $Description))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -607,7 +608,8 @@ function Test-TargetResource
             } # if
 
             if (($TimeToLiveSec) `
-                -and ($root.TimeToLiveSec -ne $TimeToLiveSec)) {
+                -and ($root.TimeToLiveSec -ne $TimeToLiveSec))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -618,7 +620,8 @@ function Test-TargetResource
             } # if
 
             if (($null -ne $EnableSiteCosting) `
-                -and (($root.Flags -contains 'Site Costing') -ne $EnableSiteCosting)) {
+                -and (($root.Flags -contains 'Site Costing') -ne $EnableSiteCosting))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -629,7 +632,8 @@ function Test-TargetResource
             } # if
 
             if (($null -ne $EnableInsiteReferrals) `
-                -and (($root.Flags -contains 'Insite Referrals') -ne $EnableInsiteReferrals)) {
+                -and (($root.Flags -contains 'Insite Referrals') -ne $EnableInsiteReferrals))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -640,7 +644,8 @@ function Test-TargetResource
             } # if
 
             if (($null -ne $EnableAccessBasedEnumeration) `
-                -and (($root.Flags -contains 'AccessBased Enumeration') -ne $EnableAccessBasedEnumeration)) {
+                -and (($root.Flags -contains 'AccessBased Enumeration') -ne $EnableAccessBasedEnumeration))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -651,7 +656,8 @@ function Test-TargetResource
             } # if
 
             if (($null -ne $EnableRootScalability) `
-                -and (($root.Flags -contains 'Root Scalability') -ne $EnableRootScalability)) {
+                -and (($root.Flags -contains 'Root Scalability') -ne $EnableRootScalability))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -662,7 +668,8 @@ function Test-TargetResource
             } # if
 
             if (($null -ne $EnableTargetFailback) `
-                -and (($root.Flags -contains 'Target Failback') -ne $EnableTargetFailback)) {
+                -and (($root.Flags -contains 'Target Failback') -ne $EnableTargetFailback))
+            {
                 Write-Verbose -Message ( @(
                     "$($MyInvocation.MyCommand): "
                     $($LocalizedData.NamespaceRootParameterNeedsUpdateMessage) `
@@ -679,7 +686,8 @@ function Test-TargetResource
             if ($target)
             {
                 if (($ReferralPriorityClass) `
-                    -and ($target.ReferralPriorityClass -ne $ReferralPriorityClass)) {
+                    -and ($target.ReferralPriorityClass -ne $ReferralPriorityClass))
+                {
                     Write-Verbose -Message ( @(
                         "$($MyInvocation.MyCommand): "
                         $($LocalizedData.NamespaceRootTargetParameterNeedsUpdateMessage) `
@@ -689,7 +697,8 @@ function Test-TargetResource
                 } # if
 
                 if (($ReferralPriorityRank) `
-                    -and ($target.ReferralPriorityRank -ne $ReferralPriorityRank)) {
+                    -and ($target.ReferralPriorityRank -ne $ReferralPriorityRank))
+                {
                     Write-Verbose -Message ( @(
                         "$($MyInvocation.MyCommand): "
                         $($LocalizedData.NamespaceRootTargetParameterNeedsUpdateMessage) `

diff --git a/DSCResources/MSFT_DFSNamespaceServerConfiguration/MSFT_DFSNamespaceServerConfiguration.psm1 b/DSCResources/MSFT_DFSNamespaceServerConfiguration/MSFT_DFSNamespaceServerConfiguration.psm1
@@ -250,7 +250,8 @@ function Test-TargetResource
         $parameterNew = (Get-Variable -Name ($parameter.name)).Value
 
         if ($PSBoundParameters.ContainsKey($parameter.Name) `
-            -and ($parameterSource -ne $parameterNew)) {
+            -and ($parameterSource -ne $parameterNew))
+        {
             Write-Verbose -Message ( @(
                 "$($MyInvocation.MyCommand): "
                 $($LocalizedData.NamespaceServerConfigurationParameterNeedsUpdateMessage) `