Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected default value of Ensure in help #66

Closed
wants to merge 1 commit into from
Closed

Corrected default value of Ensure in help #66

wants to merge 1 commit into from

Conversation

variableresistor
Copy link

@variableresistor variableresistor commented Feb 28, 2017

For xScheduledTask


This change is Reviewable

@msftclas
Copy link

@ITGuyOU,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@PlagueHO
Copy link
Member

PlagueHO commented Jul 3, 2017

Hi @ITGuyOU - the tests seem to be failing on this one. Are you able to resolve this? One thing to note: the change may be affected by this PR that is scheduled to go in: #69

@variableresistor
Copy link
Author

Hey @PlagueHO . Is the documentation change I made causing the tests to fail? Or are you asking if I can take a look at some of the issues plaguing the PSScriptAnalyzer?

@PlagueHO
Copy link
Member

Hi @ITGuyOU - actually, I took a look at the tests that failed, and I think they may have actually been caused by a change to Pester. I think the Pester team have actually fixed the issue.

So are you able to trigger a dummy commit to force AppVeyor to run again? E.g. just make some trivial change to the README.MD or something and push it - this will tell us if the build is still failing.

@johlju
Copy link
Member

johlju commented Jul 10, 2017

@PlagueHO another tip is that you can also close and reopen the PR to trigger the tests to run again. Then there is no need to do a dummy commit.

@PlagueHO
Copy link
Member

@johlju - oh cool! Great tip! I'm not yet a repo maintainer on this one yet ( @zjalexander ), so can't do that myself. @ITGuyOU - are you able to do this?

@PlagueHO PlagueHO closed this Jul 11, 2017
@PlagueHO PlagueHO reopened this Jul 11, 2017
@msftclas
Copy link

@ITGuyOU,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@PlagueHO
Copy link
Member

Hi @ITGuyOU - unfortunately there are some merge conflicts now (due to another PR that I merged). Are you able to fix these and I'll help get any failing tests fixed up.

@PlagueHO PlagueHO added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Jul 11, 2017
@PlagueHO
Copy link
Member

@ITGuyOU - I'm going to close this one, because I've included the fix in this PR #77

@PlagueHO PlagueHO closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author response The pull request is waiting for the author to respond to comments in the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants