Adding Options parameter to Computer resource #381

nickgw · 2022-04-07T18:39:50Z

Pull Request (PR) description

Adds Options parameter to Computer resource, as defined in https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/add-computer?view=powershell-5.1#parameters

This Pull Request (PR) fixes the following issues

- Fixes #234

Task list

Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
Resource documentation added/updated in README.md in resource folder.
Resource parameter descriptions added/updated in schema.mof
and comment-based help.
Comment-based help added/updated.
Localization strings added/updated in all localization files as appropriate.
Examples appropriately added/updated.
Unit tests added/updated. See DSC Resource Testing Guidelines.
Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

PlagueHO · 2022-04-07T20:39:34Z

Hi @nickgw - it looks like the pipelines are broken. I'll fix these this weekend so that the CI can run on your build. But in the meantime I'll do a quick review of your PR to get you some suggestions. Thank you for submitting!

source/DSCResources/DSC_Computer/DSC_Computer.psm1

PlagueHO

Although the Set has been updated, it looks like there would need to be code added to the Test. In this case I'd recommend using the Compare-Object command to compare the two array of strings.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @nickgw)

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 90 at r1 (raw file):

        [Parameter()]
        [System.String()]

I think this should be an array of strings. That way you can also specify ValidateSet() to ensure the values are valid.

Code snippet:

[ValidateSet('AccountCreate','Win9XUpgrade','UnsecuredJoin','PasswordPass','JoinWithNewName','JoinReadOnly','InstallInvoke')]
[System.String[]]

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 198 at r1 (raw file):

        [Parameter()]
        [System.String()]

I think this should be an array of strings. That way you can also specify ValidateSet() to ensure the values are valid.

Code snippet:

[ValidateSet('AccountCreate','Win9XUpgrade','UnsecuredJoin','PasswordPass','JoinWithNewName','JoinReadOnly','InstallInvoke')]
[System.String[]]

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 263 at r1 (raw file):

                    #>
                    $joinOptions = New-Object System.Collections.Generic.List[string]
                    $available_options = @("AccountCreate","Win9XUpgrade","UnsecuredJoin","PasswordPass","JoinWithNewName","JoinReadOnly","InstallInvoke")

I think this whole block can be simplified a lot if the parameter is changed to an array of strings.

The validation for the PasswordPass is still needed, but you could move this whole block out into an a new Assert-ResourceProperty function that validates the combination. Like we do here: https://github.com/dsccommunity/NetworkingDsc/blob/main/source/DSCResources/DSC_Route/DSC_Route.psm1#L571

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 273 at r1 (raw file):

                                    }
                                } else {
                                    New-InvalidOperationException -Message "PasswordPass is valid only when teh UnsecuredJoin option is specified"

Can this message be defined in the localization file for en-us and referenced (e.g. $script:localizedData.InvalidOptionPasswordPassUnsecuredJoin) ? Also, regarding the wording, it is helpful to specify the parameter first e.g.: Domain Join option "PasswordPass" may not be specified if "UnsecuredJoin" is specified.

You would probably use New-InvalidArgumentOperation here and can then specify the parameter name: https://github.com/dsccommunity/DscResource.Common#new-invalidargumentexception

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 273 at r2 (raw file):

Previously, nickgw (Nick G) wrote…

I'm not 100% on how I should be using these error functions if you've got a quick doc on it.

You're using the error functions correctly - just need to use a localization string. I've added comments and links to docs above.

source/DSCResources/DSC_Computer/DSC_Computer.schema.mof, line 12 at r2 (raw file):

    [Write, Description("The value assigned here will be set as the local computer description.")] String Description;
    [Write, Description("The Active Directory Domain Controller to use to join the domain")] String Server;
    [Write, Description("Specifies advanced options for the Add-Computer join operation")] String Options;

I think this should be an array of strings too. That way you can also add ValueMap{""AccountCreate","Win9XUpgrade","UnsecuredJoin","PasswordPass","JoinWithNewName","JoinReadOnly","InstallInvoke"}, Values{"AccountCreate","Win9XUpgrade","UnsecuredJoin","PasswordPass","JoinWithNewName","JoinReadOnly","InstallInvoke"} to the MOF.

nickgw

Reviewable status: 1 of 4 files reviewed, 5 unresolved discussions (waiting on @nickgw and @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 90 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this should be an array of strings. That way you can also specify ValidateSet() to ensure the values are valid.

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 198 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this should be an array of strings. That way you can also specify ValidateSet() to ensure the values are valid.

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 273 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can this message be defined in the localization file for en-us and referenced (e.g. $script:localizedData.InvalidOptionPasswordPassUnsecuredJoin) ? Also, regarding the wording, it is helpful to specify the parameter first e.g.: Domain Join option "PasswordPass" may not be specified if "UnsecuredJoin" is specified.

You would probably use New-InvalidArgumentOperation here and can then specify the parameter name: https://github.com/dsccommunity/DscResource.Common#new-invalidargumentexception

Done.

source/DSCResources/DSC_Computer/DSC_Computer.schema.mof, line 12 at r2 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this should be an array of strings too. That way you can also add ValueMap{""AccountCreate","Win9XUpgrade","UnsecuredJoin","PasswordPass","JoinWithNewName","JoinReadOnly","InstallInvoke"}, Values{"AccountCreate","Win9XUpgrade","UnsecuredJoin","PasswordPass","JoinWithNewName","JoinReadOnly","InstallInvoke"} to the MOF.

Done.

PlagueHO · 2022-04-10T07:05:52Z

Once this PR (#384) is merged you should be able to rebase and the pipeline will work.

…noptions

codecov · 2022-04-11T22:07:10Z

Codecov Report

Merging #381 (18c0c22) into main (f679412) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #381   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        17     17           
  Lines      1682   1690    +8     
===================================
+ Hits       1520   1528    +8     
  Misses      162    162

Impacted Files	Coverage Δ
source/DSCResources/DSC_Computer/DSC_Computer.psm1	`89% <100%> (+<1%)`	⬆️

PlagueHO · 2022-04-12T04:36:48Z

Hey @nickgw - your unit tests are failing because this Get-InvalidArgumentException should be Get-InvalidArgumentRecord.

PlagueHO

Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @nickgw and @PlagueHO)

tests/Unit/DSC_Computer.Tests.ps1, line 1099 at r6 (raw file):

                It 'Should throw if PasswordPass is present in options without UnsecuredJoin' {
                    $errorRecord = Get-InvalidArgumentException `

Should be:

Code snippet:

Get-InvalidArgumentRecord

tests/Unit/DSC_Computer.Tests.ps1, line 1122 at r6 (raw file):

                It 'Should throw if PasswordPass and UnsecuredJoin is present but credential username is not null' {
                    $errorRecord = Get-InvalidArgumentException `

Should be:

Code snippet:

Get-InvalidArgumentRecord

nickgw

Hey, I've made this change but the Unit tests for Computer continue to fail. I'm not certain what I'm doing wrong here, and the test output is not the most helpful.

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @nickgw and @PlagueHO)

nickgw

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 263 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this whole block can be simplified a lot if the parameter is changed to an array of strings.

The validation for the PasswordPass is still needed, but you could move this whole block out into an a new Assert-ResourceProperty function that validates the combination. Like we do here: https://github.com/dsccommunity/NetworkingDsc/blob/main/source/DSCResources/DSC_Route/DSC_Route.psm1#L571

I've added an Assert-ResourceProperty function to handle this validation.

tests/Unit/DSC_Computer.Tests.ps1, line 1099 at r6 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Should be:

Resolved, but tests are still failing

tests/Unit/DSC_Computer.Tests.ps1, line 1122 at r6 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Should be:

Resolved, but tests are still failing

PlagueHO · 2022-04-13T07:01:21Z

I'll have a look at test failures tomorrow night.

PlagueHO · 2022-04-20T05:57:27Z

Sorry about the delay in looking at this @nickgw - got a bit snowed under. Will try again tomorrow night.

nickgw · 2022-04-20T14:52:13Z

Sorry about the delay in looking at this @nickgw - got a bit snowed under. Will try again tomorrow night.

Thanks, appreciate your time!

PlagueHO

Ok @nickgw - figured out what was wrong. Have added comments below. Can you also add some tests to cover passing the new parameter to Test-TargetResource and Set-TargetResource?

Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @nickgw and @PlagueHO)

tests/Unit/DSC_Computer.Tests.ps1, line 1193 at r8 (raw file):

                        -ArgumentName 'Credential'

                    Assert-ResourceProperty `

Doh - Not sure how I missed this. Should be:

{
    Assert-ResourceProperty `
        -Name $env:COMPUTERNAME `
        -Options @('PasswordPass', 'UnsecuredJoin') `
        -Credential $machinePassword `
        -Verbose
} | Should -Throw $errorRecord

tests/Unit/DSC_Computer.Tests.ps1, line 1205 at r8 (raw file):

                        -ArgumentName 'PasswordPass'

                    Assert-ResourceProperty `

Should be:

{
    Assert-ResourceProperty `
        -Name $env:COMPUTERNAME `
        -Options @('PasswordPass') `
        -Verbose
} | Should -Throw $errorRecord

nickgw

I'm not 100% sure on how I would add tests to Test. The parameter set will validate all the passed options, but test shouldn't do anything else with the Options param otherwise.

Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @PlagueHO)

tests/Unit/DSC_Computer.Tests.ps1, line 1122 at r6 (raw file):

Previously, nickgw (Nick G) wrote…

Resolved, but tests are still failing

Done

tests/Unit/DSC_Computer.Tests.ps1, line 1193 at r8 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Doh - Not sure how I missed this. Should be:

{
    Assert-ResourceProperty `
        -Name $env:COMPUTERNAME `
        -Options @('PasswordPass', 'UnsecuredJoin') `
        -Credential $machinePassword `
        -Verbose
} | Should -Throw $errorRecord

Done. Tests are passing now.

tests/Unit/DSC_Computer.Tests.ps1, line 1205 at r8 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Should be:

{
    Assert-ResourceProperty `
        -Name $env:COMPUTERNAME `
        -Options @('PasswordPass') `
        -Verbose
} | Should -Throw $errorRecord

Done. Tests are passing now.

nickgw · 2022-05-10T04:35:01Z

Hey @PlagueHO, please let me know when you get a chance to review this again!

PlagueHO · 2022-05-11T04:21:56Z

Hi @nickgw - sorry about the delay. I'll get onto this this weekend (snowed under with day job). I do notice that the code coverage has dropped ag bit - I think it just needs a unit test that covers these two lines by calling Set with the Options parameter defined.

PlagueHO

Reviewed 1 of 2 files at r4, 1 of 1 files at r5, 1 of 3 files at r6, 1 of 1 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @nickgw)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 272 at r11 (raw file):

                    #>
                    Assert-ResourceProperty @PSBoundParameters
                    $addComputerParameters.Add("Options", $Options)

Can you convert the "Options" to single quotes? E.g. 'Options'

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 761 at r11 (raw file):

    if (
        ($options -contains 'PasswordPass') -and

The inner () aren't needed. This should be formatted like this:

    if ($options -contains 'PasswordPass' -and
        $options -notcontains 'UnsecuredJoin')

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 765 at r11 (raw file):

    )
    {
        New-InvalidArgumentException -Message $script:localizedData.InvalidOptionPasswordPassUnsecuredJoin -ArgumentName 'PasswordPass'

Can you shorten this line by back-ticking? We try to stay below 100 chars:

New-InvalidArgumentException `
    -Message $script:localizedData.InvalidOptionPasswordPassUnsecuredJoin `
    -ArgumentName 'PasswordPass'

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 768 at r11 (raw file):

    }

    if (

The inner () aren't needed. This should be formatted like this:

    if ($options -contains 'PasswordPass' -and
        $options -contains 'UnsecuredJoin')

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 773 at r11 (raw file):

    )
    {
        if ( -not [System.String]::IsNullOrEmpty($Credential.UserName) )

Could this if condition be added to the previous if? E.g.

    if ($options -contains 'PasswordPass' -and
        $options -contains 'UnsecuredJoin' -and 
         -not [System.String]::IsNullOrEmpty($Credential.UserName))

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 775 at r11 (raw file):

        if ( -not [System.String]::IsNullOrEmpty($Credential.UserName) )
        {
            New-InvalidArgumentException -Message $script:localizedData.InvalidOptionCredentialUnsecuredJoinNullUsername -ArgumentName 'Credential'

Can you shorten this line by back-ticking? We try to stay below 100 chars.

source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1 line 19 at r11 (raw file):

    DomainNameAndWorkgroupNameError = Only DomainName or WorkGroupName can be specified at once.
    ComputerNotInDomainMessage = This machine is not a domain member.
    InvalidOptionPasswordPassUnsecuredJoin = Domain Join option "PasswordPass" may not be specified if "UnsecuredJoin" is specified.

Can we use single quotes instead of double quotes here?

source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1 line 20 at r11 (raw file):

    ComputerNotInDomainMessage = This machine is not a domain member.
    InvalidOptionPasswordPassUnsecuredJoin = Domain Join option "PasswordPass" may not be specified if "UnsecuredJoin" is specified.
    InvalidOptionCredentialUnsecuredJoinNullUsername = "Credential" username must be null if "UnsecuredJoin" is specified.

Can we use single quotes instead of double quotes here?

PlagueHO

Looking really good @nickgw - just some minor tweaks and unit tests and should be good to go.

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @nickgw)

nickgw

Reviewable status: 2 of 5 files reviewed, 8 unresolved discussions (waiting on @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 272 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you convert the "Options" to single quotes? E.g. 'Options'

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 761 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

The inner () aren't needed. This should be formatted like this:
    if ($options -contains 'PasswordPass' -and
        $options -notcontains 'UnsecuredJoin')

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 765 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you shorten this line by back-ticking? We try to stay below 100 chars:
New-InvalidArgumentException `
    -Message $script:localizedData.InvalidOptionPasswordPassUnsecuredJoin `
    -ArgumentName 'PasswordPass'

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 768 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

The inner () aren't needed. This should be formatted like this:
    if ($options -contains 'PasswordPass' -and
        $options -contains 'UnsecuredJoin')

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 773 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Could this if condition be added to the previous if? E.g.

    if ($options -contains 'PasswordPass' -and
        $options -contains 'UnsecuredJoin' -and 
         -not [System.String]::IsNullOrEmpty($Credential.UserName))

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 775 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you shorten this line by back-ticking? We try to stay below 100 chars.

Done.

source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1 line 19 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can we use single quotes instead of double quotes here?

Done.

source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1 line 20 at r11 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can we use single quotes instead of double quotes here?

Done.

nickgw

Hey @PlagueHO , really appreciate the time and comments. I think this is all set now!

Reviewable status: 2 of 5 files reviewed, 8 unresolved discussions (waiting on @PlagueHO)

PlagueHO · 2022-05-20T03:57:01Z

Cool - thanks @nickgw - I'll finish review this weekend!

PlagueHO

Reviewed 3 of 3 files at r12, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

PlagueHO · 2022-05-27T07:34:10Z

Looks like an intermittent build failure (integration tests on WS2022). So, I've kicked the build again and hopefully will deploy the preview release.

nickgw added 2 commits April 7, 2022 14:39

Adding options to commands

3b873c7

adding option sto schema

21022b1

PlagueHO added the needs review The pull request needs a code review. label Apr 7, 2022

updating changelog.md

222fad0

nickgw commented Apr 7, 2022

View reviewed changes

source/DSCResources/DSC_Computer/DSC_Computer.psm1 Outdated Show resolved Hide resolved

PlagueHO requested changes Apr 7, 2022

View reviewed changes

Nick Germany added 3 commits April 7, 2022 18:26

validateset and add localized errors

5f31e68

updating error message

bfb800f

updating values in mof

ea2fa03

nickgw commented Apr 7, 2022

View reviewed changes

Merge remote-tracking branch 'origin/main' into ngermany_adddomainjoi…

9b66124

…noptions

Nick Germany added 11 commits April 11, 2022 20:09

Simplifying options parsing

d65c47d

fixing type in schema

2f9d367

Updating if statements to match rules

d7b0925

Adding tests

755521f

fixing tests

34b5b7a

add error record

fcacef9

Updating parameters to mock error message

5ec884e

use correct error func

4074396

use correct error func

87a96d6

why was i splatting

5cc4b3e

why wont this build

9b6136f

PlagueHO requested changes Apr 12, 2022

View reviewed changes

nickgw and others added 3 commits April 12, 2022 09:37

Using invalidargumentrecord

d0de6c9

Use assert-resourceproperty

3f559b3

fixing merge conflict

50383da

Nick Germany added 2 commits April 12, 2022 11:14

reverting settings change

4c809dd

re-adding errorrecord

d363a85

nickgw commented Apr 12, 2022

View reviewed changes

PlagueHO requested changes Apr 21, 2022

View reviewed changes

nickgw and others added 6 commits April 23, 2022 14:45

Fixing unit tests for computer

842ecd8

fixing assertion for null username

482c191

Use correct parameter in assert-resourceproperty

57c7446

fix hashtable

487a999

pass credential

203290a

no need for machine password anymore

322e0c7

nickgw commented Apr 23, 2022

View reviewed changes

PlagueHO requested changes May 13, 2022

View reviewed changes

PlagueHO reviewed May 13, 2022

View reviewed changes

nickgw added 3 commits May 13, 2022 15:33

Updating syntax and adding a test for passing Options to set

82c362e

Fixing with backtick

7877c5d

Reformatting

18c0c22

nickgw commented May 13, 2022

View reviewed changes

PlagueHO approved these changes May 23, 2022

View reviewed changes

PlagueHO merged commit 49b3657 into dsccommunity:main May 23, 2022

nickgw deleted the ngermany_adddomainjoinoptions branch May 23, 2022 14:55

johlju removed the needs review The pull request needs a code review. label Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Options parameter to Computer resource #381

Adding Options parameter to Computer resource #381

nickgw commented Apr 7, 2022 •

edited

Loading

PlagueHO commented Apr 7, 2022

PlagueHO left a comment

nickgw left a comment

PlagueHO commented Apr 10, 2022

codecov bot commented Apr 11, 2022 •

edited

Loading

PlagueHO commented Apr 12, 2022

PlagueHO left a comment

nickgw left a comment

nickgw left a comment

PlagueHO commented Apr 13, 2022

PlagueHO commented Apr 20, 2022

nickgw commented Apr 20, 2022

PlagueHO left a comment

nickgw left a comment

nickgw commented May 10, 2022

PlagueHO commented May 11, 2022 •

edited

Loading

PlagueHO left a comment

PlagueHO left a comment

nickgw left a comment

nickgw left a comment

PlagueHO commented May 20, 2022

PlagueHO left a comment

PlagueHO commented May 27, 2022

Adding Options parameter to Computer resource #381

Adding Options parameter to Computer resource #381

Conversation

nickgw commented Apr 7, 2022 • edited Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

PlagueHO commented Apr 7, 2022

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO commented Apr 10, 2022

codecov bot commented Apr 11, 2022 • edited Loading

Codecov Report

PlagueHO commented Apr 12, 2022

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO commented Apr 13, 2022

PlagueHO commented Apr 20, 2022

nickgw commented Apr 20, 2022

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

nickgw commented May 10, 2022

PlagueHO commented May 11, 2022 • edited Loading

PlagueHO left a comment

Choose a reason for hiding this comment

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO commented May 20, 2022

PlagueHO left a comment

Choose a reason for hiding this comment

PlagueHO commented May 27, 2022

nickgw commented Apr 7, 2022 •

edited

Loading

codecov bot commented Apr 11, 2022 •

edited

Loading

PlagueHO commented May 11, 2022 •

edited

Loading