Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused environment variables from pipeline #372

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 20, 2021

Pull Request (PR) description

This PR updates the pipeline to correct the last pipeline task and remove unused environment variables.

This Pull Request (PR) fixes the following issues

N/A

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #372 (02d0cf0) into main (e645c7e) will increase coverage by 2%.
The diff coverage is 86%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #372    +/-   ##
====================================
+ Coverage    88%    90%    +2%     
====================================
  Files        14     17     +3     
  Lines      1469   1682   +213     
====================================
+ Hits       1294   1520   +226     
+ Misses      175    162    -13     
Impacted Files Coverage Δ
...gementDsc.Common/ComputerManagementDsc.Common.psm1 39% <39%> (ø)
...Resources/DSC_ScheduledTask/DSC_ScheduledTask.psm1 86% <78%> (ø)
source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1 98% <92%> (ø)
...s/DSC_WindowsCapability/DSC_WindowsCapability.psm1 97% <95%> (ø)
...urces/DSC_WindowsEventLog/DSC_WindowsEventLog.psm1 96% <96%> (ø)
source/DSCResources/DSC_Computer/DSC_Computer.psm1 88% <100%> (ø)
...iguration/DSC_IEEnhancedSecurityConfiguration.psm1 100% <100%> (ø)
...s/DSC_OfflineDomainJoin/DSC_OfflineDomainJoin.psm1 89% <100%> (ø)
...Resources/DSC_PendingReboot/DSC_PendingReboot.psm1 98% <100%> (ø)
...urce/DSCResources/DSC_PowerPlan/DSC_PowerPlan.psm1 100% <100%> (ø)
... and 13 more

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit 408decd into dsccommunity:main Apr 20, 2021
@johlju johlju removed the needs review The pull request needs a code review. label Apr 20, 2021
@PlagueHO PlagueHO deleted the Pipeline-Corrections branch April 20, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants