ScheduledTask: Fixed execution account missing domain name

[jensotto]

Pull Request (PR) description

Improved PR #351 to include domain accounts.

This Pull Request (PR) fixes the following issues

Fixes #352
Possibly fixes or Improves #144

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[PlagueHO]

Hi @jensotto - thanks for submitting this. It looks like the HQRM tests are failing because an entry hasn't been added to the CHANGELOG.md: See the Update the Changelog section in: https://dsccommunity.org/guidelines/contributing/

[jensotto]

It already contains a message for that change so I didn't add any further comments: Fixed issue with ExecuteAsCredential not returning fully qualified username on newer versions of Windows 10 and Windows Server 2019 - Fixes Issue #352.

[PlagueHO]

Ah, I see. Unfortunately for the tests to pass you'll need to make a correction message.

[jensotto]

Ok, I have mad a small change to the existing entry in changelog.

[PlagueHO]

Hi @jensotto - sorry about the delays in getting to this. Can you resolve the conflicts and I'll review?

[jensotto]

@PlagueHO conflicts resolved

[PlagueHO]

Thanks @jensotto - just some minor style tweaks to line length then can merge.

Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jensotto)

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 1453 at r4 (raw file):

        if ($username -match "$ENV:COMPUTERNAME\\" -and $currentValues.ExecuteAsCredential)
        {
            $currentValues.ExecuteAsCredential = Set-DomainNameInAccountName -AccountName $currentValues.ExecuteAsCredential -DomainName $ENV:COMPUTERNAME

Can you reduce the line length of this line by using:

$currentValues.ExecuteAsCredential = Set-DomainNameInAccountName `
    -AccountName $currentValues.ExecuteAsCredential `
    -DomainName $ENV:COMPUTERNAME

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 1458 at r4 (raw file):

        if ($username -match "$ENV:USERDOMAIN\\" -and $currentValues.ExecuteAsCredential)
        {
            $currentValues.ExecuteAsCredential = Set-DomainNameInAccountName -AccountName $currentValues.ExecuteAsCredential -DomainName $ENV:USERDOMAIN

Can you reduce the line length of this line by using:

$currentValues.ExecuteAsCredential = Set-DomainNameInAccountName `
    -AccountName $currentValues.ExecuteAsCredential `
v    -DomainName $ENV:USERDOMAIN

[jensotto]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @PlagueHO)

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 1453 at r4 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you reduce the line length of this line by using:

$currentValues.ExecuteAsCredential = Set-DomainNameInAccountName `
    -AccountName $currentValues.ExecuteAsCredential `
    -DomainName $ENV:COMPUTERNAME

Done.

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 1458 at r4 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you reduce the line length of this line by using:

$currentValues.ExecuteAsCredential = Set-DomainNameInAccountName `
    -AccountName $currentValues.ExecuteAsCredential `
v    -DomainName $ENV:USERDOMAIN

Done.

[PlagueHO]

Reviewed 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jensotto)