Convert to use DSCResource.Common Module

[PlagueHO]

Pull Request (PR) description

• Updated to use the common module DscResource.Common - Fixes Issue #327.
• Fixed build failures caused by changes in ModuleBuilder module v1.7.0
  by changing CopyDirectories to CopyPaths - Fixes Issue #332.

This Pull Request (PR) fixes the following issues

• Fixes Correct Build.YML to Support ModuleBuilder 1.7.0 #332
• Fixes Convert Module to use DSCResource.Common #327

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you get time?

---

This change is 

[johlju]

Reviewed 23 of 23 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

---

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 16 at r1 (raw file):

-DefaultUICulture 'en-US'

I haven't tried it myself yet, but a recent change to the function made this the default, so just calling Get-LocalizedData should work. But this is good as-is.

---

source/Modules/ComputerManagementDsc.Common/ComputerManagementDsc.Common.psm1, line 634 at r1 (raw file):

'Get-RegistryPropertyValue'

This is a one we use in SqlServerDsc too. We should add it to Common eventually. Good as-is. Non-blocking.

[PlagueHO]

Reviewable status: 7 of 23 files reviewed, all discussions resolved (waiting on @johlju)

---

source/DSCResources/DSC_Computer/DSC_Computer.psm1, line 16 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-DefaultUICulture 'en-US'

I haven't tried it myself yet, but a recent change to the function made this the default, so just calling Get-LocalizedData should work. But this is good as-is.

I gave it a try without the -DefaultUICulture - unfortunately it looks like there is a bug - it doesn't find the data file:

I'll submit a fix to DscResource.Common.

[johlju]

Would be great with a fix!