Refactor Module to Remove Harness - Fixes #188 #214
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #214 +/- ##
===================================
- Coverage 90% 83% -7%
===================================
Files 8 10 +2
Lines 858 1068 +210
===================================
+ Hits 775 891 +116
- Misses 83 177 +94 |
|
I will get on this this weekend, to much at the day job at the moment. 🙂 |
There was a problem hiding this comment.
Reviewed 95 of 95 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 2 at r1 (raw file):
#region HEADER $script:dscModuleName = 'DscResource.Template'
Duplicate. Throughout all the tests.
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 3 at r1 (raw file):
#region HEADER $script:dscModuleName = 'DscResource.Template' $script:DSCModuleName = 'ComputerManagementDsc'
$script:dscModuleName (lower-case 'dsc'). Throughout all the tests..
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 4 at r1 (raw file):
$script:DSCResourceName
$script:dscResourceName (lower-case 'dsc'). Throughout all the tests..
There was a problem hiding this comment.
All good catches! Done!
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 2 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Duplicate. Throughout all the tests.
Done.
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 3 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
$script:dscModuleName (lower-case 'dsc'). Throughout all the tests..
Done.
Tests/Integration/MSFT_PowerShellExecutionPolicy.Integration.Tests.ps1, line 4 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
$script:DSCResourceName$script:dscResourceName (lower-case 'dsc'). Throughout all the tests..
Done.
There was a problem hiding this comment.
Reviewed 13 of 13 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Tests/Unit/MSFT_VirtualMemory.Tests.ps1, line 12 at r2 (raw file):
& git.exe
Non-blocking. Why git.exe here? It is not in any other tests file? 🙂
There was a problem hiding this comment.
Reviewable status: 94 of 95 files reviewed, all discussions resolved (waiting on @johlju)
Tests/Unit/MSFT_VirtualMemory.Tests.ps1, line 12 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
& git.exeNon-blocking. Why git.exe here? It is not in any other tests file? 🙂
I have no idea! I've changed it now. Can you approve this one again?
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
|
@PlagueHO All good now! I will rebase my PR as soon you have merged this one. 😃 |
Pull Request (PR) description
This PR refactors the module to remove the harness structure and enable Example publishing to the PS Gallery. I also updated the test headers to meet the latest versions in the template.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju - would you mind reviewing? Thank you as always!
This change is