-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScheduledTask: IdleWaitTimeout fix & BuiltInAccount added #187
Conversation
This reverts commit 20a7b58.
fix markdown format bug
@djwork - looks like you've got some merge conflicts there - can you rebase against Dev? |
Codecov Report
@@ Coverage Diff @@
## dev #187 +/- ##
==================================
- Coverage 90% 89% -1%
==================================
Files 7 7
Lines 724 758 +34
==================================
+ Hits 657 681 +24
- Misses 67 77 +10 |
@PlagueHO did my rebase come through? I am new to pull requests and rebasing |
…oss-time-zone-support ScheduledTask: Synchronize across time zone support
Added .VSCode settings for applying DSC PSSA rules - Fixes #189
Is this still waiting on code fix? |
Hi @djwork - sorry I haven't had a chance to look at this - will tonight. But in the mean time you've got some merge conflicts that need to be resolved. Let me know if you get stuck - always happy to help (and great job with the rebase - it is one of the harder techniques to master). |
@PlagueHO fixed the merge conflicts |
Hi @djwork - I think the rebase might have gone a bit wrong (I've been there more times than I can count 😁). Because you've not made a branch in your repo (just developed in dev), what you'd need to do is rebase against the upstream fork dev branch (I'm assuming you've registered a remote fork git rebase upstream dev It should the replay all your commits onto the upstream dev branch. I generally create a branch of my own dev and then just pull all change from the upstream fork into my dev branch and do a squash rebase before I commit (to get rid of all my commits that say things like "This better work" and "another try" 😁) |
I'm going to abandon this pull request and try again with a fresh one |
Pull Request (PR) description
ScheduledTask:
Fix to IdleWaitTimeout returned from Get-TargetResource always null
Added BuiltInAccount property to support running task as a builtin account
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is