Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify an OU upon Domain Join #13

Merged
merged 9 commits into from
Jan 5, 2016
Merged

Add the ability to specify an OU upon Domain Join #13

merged 9 commits into from
Jan 5, 2016

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Oct 20, 2015

No description provided.

@msftclas
Copy link

Hi @PrahlM93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@PrahlM93, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mprahl mprahl mentioned this pull request Oct 20, 2015
@@ -91,7 +91,7 @@ InModuleScope MSFT_xComputer {
It 'Should return a hashtable containing Name,DomainName, Credential, UnjoinCredential and WorkGroupName' {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add the new keys to this statement.

@mprahl
Copy link
Contributor Author

mprahl commented Oct 23, 2015

@tysonjhayes Any other suggestions?

@tysonjhayes
Copy link

Nothing that needs to be handled in this PR, I'd like to see the verb-noun changed for everything but that's out of scope for this. 😁

Looks good to me though, thanks!

@tysonjhayes
Copy link

@TravisEz13 @KarolKaczmarek either one of you able to lend a hand by merging this so I can close out #6 ?

@mprahl
Copy link
Contributor Author

mprahl commented Dec 21, 2015

@tysonjhayes, is there any news on whether or not this will be merged?

@MCrank
Copy link

MCrank commented Jan 2, 2016

@tysonjhayes I too would like for this to get merged. Surprised this was not included initially.

tysonjhayes pushed a commit that referenced this pull request Jan 5, 2016
Add the ability to specify an OU upon Domain Join
@tysonjhayes tysonjhayes merged commit d715779 into dsccommunity:dev Jan 5, 2016
@tysonjhayes
Copy link

Sorry about the delay here guys. This is now merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants