-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to specify an OU upon Domain Join #13
Conversation
Hi @PrahlM93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@PrahlM93, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
@@ -91,7 +91,7 @@ InModuleScope MSFT_xComputer { | |||
It 'Should return a hashtable containing Name,DomainName, Credential, UnjoinCredential and WorkGroupName' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably add the new keys to this statement.
@tysonjhayes Any other suggestions? |
Nothing that needs to be handled in this PR, I'd like to see the verb-noun changed for everything but that's out of scope for this. 😁 Looks good to me though, thanks! |
@TravisEz13 @KarolKaczmarek either one of you able to lend a hand by merging this so I can close out #6 ? |
@tysonjhayes, is there any news on whether or not this will be merged? |
@tysonjhayes I too would like for this to get merged. Surprised this was not included initially. |
Add the ability to specify an OU upon Domain Join
Sorry about the delay here guys. This is now merged in. |
No description provided.