Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests to meet Pester V4 guidelines - Fixes #106 #129

Merged
merged 2 commits into from
Dec 28, 2017
Merged

Updated tests to meet Pester V4 guidelines - Fixes #106 #129

merged 2 commits into from
Dec 28, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Dec 25, 2017 •
edited by joeyaiello
Loading

Pull Request (PR) description
Updated the tests to meet the Pester v4 guidelines.

This Pull Request (PR) fixes the following issues:
#106

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - would you mind looking this one over if you have a chance? I just used the standard script to do the conversion.

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Dec 25, 2017
@PlagueHO PlagueHO added this to the HQRM milestone Dec 25, 2017
@PlagueHO PlagueHO self-assigned this Dec 25, 2017
@johlju
Copy link
Member

johlju commented Dec 26, 2017

:lgtm:

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@PlagueHO PlagueHO merged commit f3e2043 into dsccommunity:dev Dec 28, 2017
@PlagueHO PlagueHO deleted the Issue-106 branch December 28, 2017 05:43
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PlagueHO PlagueHO

Labels
None yet
Projects
None yet
Milestone
HQRM
Development

Successfully merging this pull request may close these issues.
3 participants
@PlagueHO @johlju @joeyaiello