Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed $ca parameter #43

Closed
wants to merge 17 commits into from
Closed

Changed $ca parameter #43

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
998e100
Changed $ca parameter
svenvanrijen Jan 31, 2017
a3dddd3
Revert "Changed $ca parameter"
svenvanrijen Feb 9, 2017
92f6117
Revert "Revert "Changed $ca parameter""
svenvanrijen Feb 9, 2017
230fce4
Changed all lines as discussed under PR 43 and issue 42
svenvanrijen Feb 15, 2017
3494dfa
Chnaged unit test
svenvanrijen Feb 15, 2017
731872f
Revert "Chnaged unit test"
svenvanrijen Mar 2, 2017
09f59c5
Merge remote-tracking branch 'refs/remotes/PowerShell/dev' into dev
svenvanrijen Mar 2, 2017
cbd895a
commit tests
svenvanrijen Mar 2, 2017
8f402ac
Revert "commit tests"
svenvanrijen Mar 2, 2017
97ca5c6
Revert "Changed all lines as discussed under PR 43 and issue 42"
svenvanrijen Mar 2, 2017
79ed95f
Revert "Revert "Changed all lines as discussed under PR 43 and issue …
svenvanrijen Mar 2, 2017
3cda7fc
Merge remote-tracking branch 'refs/remotes/PowerShell/dev' into dev
svenvanrijen Mar 6, 2017
51527c4
Merge branch 'dev' of https://github.com/svenvanrijen/xCertificate in…
svenvanrijen Mar 6, 2017
5867cde
Merge tests
svenvanrijen Mar 6, 2017
80e8447
changed unit test to match actual script
svenvanrijen Mar 6, 2017
91e8ad6
changed test again
svenvanrijen Mar 6, 2017
086f6f3
Revert "Changed $ca parameter"
svenvanrijen Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DSCResources/MSFT_xCertReq/MSFT_xCertReq.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ function Get-TargetResource
)

# The certificate authority, accessible on the local area network
$ca = "'$CAServerFQDN\$CARootName'"
$ca = "$CAServerFQDN\$CARootName"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Please document your change on the README.md file https://github.com/PowerShell/xCertificate/blob/dev/ReadMe.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just all changed lines as discussed under PR 43 and issue 42. Also documented the changes in README.md file as requested.


Write-Verbose -Message ( @(
"$($MyInvocation.MyCommand): "
Expand Down Expand Up @@ -278,7 +278,7 @@ function Set-TargetResource
)

# The certificate authority, accessible on the local area network
$ca = "'$CAServerFQDN\$CARootName'"
$ca = "$CAServerFQDN\$CARootName"

Write-Verbose -Message ( @(
"$($MyInvocation.MyCommand): "
Expand Down Expand Up @@ -589,7 +589,7 @@ function Test-TargetResource
)

# The certificate authority, accessible on the local area network
$ca = "'$CAServerFQDN\$CARootName'"
$ca = "$CAServerFQDN\$CARootName"

# If the Subject does not contain a full X500 path, construct just the CN
if (($Subject.split('=').count) -eq 1)
Expand Down