Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xPfxImport DSC Resource #12

Merged
merged 4 commits into from
Nov 7, 2015

Conversation

briantist
Copy link

Adds the xPfxImport resource, see PowerShell/DscResources#58

@KarolKaczmarek KarolKaczmarek added the needs review The pull request needs a code review. label Oct 12, 2015
@olljanat
Copy link

Very nice feature and works fine at least on my lab :)

Hopefully it will be merged to master on some day.

@briantist
Copy link
Author

Thanks @olljanat , I hope so too!

@mgreenegit
Copy link
Contributor

This is very useful. It has been a common ask to be able to handle publicly trusted certs. Great set of tests. I haven't validated it in a lab environment but I see someone has already, so I think we are good to go.

KarolKaczmarek added a commit that referenced this pull request Nov 7, 2015
Adding xPfxImport DSC Resource
@KarolKaczmarek KarolKaczmarek merged commit 502b82d into dsccommunity:dev Nov 7, 2015
@KarolKaczmarek KarolKaczmarek removed the needs review The pull request needs a code review. label Nov 7, 2015
@briantist
Copy link
Author

@KarolKaczmarek / @mgreenegit great news, glad to see it merged. Do you guys have a set schedule or roadmap for the changes in dev to make it into master? Thanks!

@KarolKaczmarek
Copy link
Contributor

We tend to merge into master and release to PS gallery every few weeks, the next release is planned in about 3 weeks. Until then, feel free to use feed with our development builds: https://github.com/powershell/dscresources/#development-builds

@KarolKaczmarek
Copy link
Contributor

Also, thanks a lot for contributing @briantist and sorry it took so long to review and merge this PR!

@briantist
Copy link
Author

Thank you @KarolKaczmarek ; glad to help. I hope to contribute more in the future.

kwirkykat pushed a commit that referenced this pull request Nov 19, 2016
Merge upstream dev Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants