Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADObjectPermissionEntry: Fix escaping issue when getting/setting ACLs #716

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Borgquite
Copy link
Contributor

@Borgquite Borgquite commented Aug 19, 2024

Pull Request (PR) description

Fixes #675 - when using ADObjectPermissionEntry to configure an ACL on a Path that requires escaping (comma, backslash, hash, plus etc), the command fails with 'The object name has bad syntax'

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98%. Comparing base (7c3feec) to head (61fd9e1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #716   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        26     26           
  Lines      3720   3720           
===================================
  Hits       3651   3651           
  Misses       69     69           
Files with missing lines Coverage Δ
...tPermissionEntry/MSFT_ADObjectPermissionEntry.psm1 100% <100%> (ø)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Borgquite)

@johlju johlju merged commit cb46d63 into dsccommunity:main Aug 19, 2024
8 checks passed
@Borgquite Borgquite deleted the escapingfix branch August 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADObjectPermissionEntry: The object name has bad syntax when configuring OU which requires escaped character
2 participants