Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline #704

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix pipeline #704

merged 2 commits into from
Feb 9, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 9, 2024

Pull Request (PR) description

  • Move test pipeline to Windows PowerShell. The hosted agent was updated
    to PowerShell 7.4.1. That broke the ASKDSKey unit tests that has a helper
    function (Copy-ArrayObjects) that serializes objects.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (131fb75) 98% compared to head (617de4f) 98%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #704   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3471   3471           
===================================
  Hits       3402   3402           
  Misses       69     69           

see 1 file with indirect coverage changes

@johlju johlju merged commit cb66232 into dsccommunity:main Feb 9, 2024
7 checks passed
@johlju johlju deleted the fix/pipeline-files branch February 9, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant