Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADSRootKey: Resolved 'String was not recognized as a valid DateTime' in non-US cultures #703

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Borgquite
Copy link
Contributor

@Borgquite Borgquite commented Feb 9, 2024

Pull Request (PR) description

Fix #702 where 'String was not recognised as a valid DateTime' can occur with non en-US cultures

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju
Copy link
Member

johlju commented Feb 9, 2024

I fixed the test pipeline, it failed on an unrelated error. I seems a recent update to PS 7.4.1 on the build worker was not compatible with the unit tests. If you pull in changes from main the tests should not fail, at least not on that unrelated error. 🙂

@Borgquite Borgquite reopened this Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (131fb75) 98% compared to head (1f0feb9) 98%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #703   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3471   3471           
===================================
  Hits       3402   3402           
  Misses       69     69           
Files Coverage Δ
...urce/DSCResources/MSFT_ADKDSKey/MSFT_ADKDSKey.psm1 100% <100%> (ø)

... and 1 file with indirect coverage changes

@Borgquite
Copy link
Contributor Author

@johlju Ah, thank you. I saw the test error but couldn't work out for the life of me how my simple tweak was breaking the test - amazing coincidence that the issues was also in the ADSRootKey test! :D

@johlju johlju added the needs review The pull request needs a code review. label Feb 12, 2024
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Borgquite)

@johlju johlju merged commit fcc8b5d into dsccommunity:main Feb 12, 2024
8 checks passed
@johlju johlju removed the needs review The pull request needs a code review. label Feb 12, 2024
@johlju
Copy link
Member

johlju commented Feb 12, 2024

@Borgquite thanks for this! It will release in a preview shortly, let me know that it works and I make a full release.

@Borgquite
Copy link
Contributor Author

@johlju All looks good from here - good to release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADSRootKey: Fails with 'String was not recognized as a valid DateTime' exception
2 participants