-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADSRootKey: Resolved 'String was not recognized as a valid DateTime' in non-US cultures #703
Conversation
I fixed the test pipeline, it failed on an unrelated error. I seems a recent update to PS 7.4.1 on the build worker was not compatible with the unit tests. If you pull in changes from main the tests should not fail, at least not on that unrelated error. 🙂 |
d562bcc
to
cb66232
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
===================================
Coverage 98% 98%
===================================
Files 25 25
Lines 3471 3471
===================================
Hits 3402 3402
Misses 69 69
|
@johlju Ah, thank you. I saw the test error but couldn't work out for the life of me how my simple tweak was breaking the test - amazing coincidence that the issues was also in the ADSRootKey test! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Borgquite)
@Borgquite thanks for this! It will release in a preview shortly, let me know that it works and I make a full release. |
@johlju All looks good from here - good to release :) |
Pull Request (PR) description
Fix #702 where 'String was not recognised as a valid DateTime' can occur with non en-US cultures
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is