Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADKDSKey: Fixes #648, the resource did not work due to a non-working date conversion #649

Merged
merged 3 commits into from
May 1, 2022

Conversation

raandree
Copy link
Contributor

@raandree raandree commented Apr 6, 2021

Pull Request (PR) description

The resource did not work due to a non-working date conversion as described in #648.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #649 (bfddebb) into main (04f5f39) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #649   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68           
Impacted Files Coverage Δ
...urce/DSCResources/MSFT_ADKDSKey/MSFT_ADKDSKey.psm1 100% <100%> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Apr 10, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @raandree)

@johlju
Copy link
Member

johlju commented May 1, 2022

Let us merge this based on the #648 (comment).

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels May 1, 2022
@johlju johlju merged commit 715201d into dsccommunity:main May 1, 2022
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADKDSKey Resource does does not work
2 participants