Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryDsc: Fix CI Pipeline and DscResource.Common Module Import #614

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 23, 2020

Pull Request (PR) description

This PR fixes the CI pipeline by pinning the Pester module to v4.10.1 and updating the DscResource.Common module to v0.9.0.

It also restores importing the DscResource.Common module import in the ActiveDirectoryDsc.Common module that was incorrectly disabled.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #614 into master will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #614   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          24     24           
  Lines        3109   3110    +1     
=====================================
+ Hits         3048   3049    +1     
  Misses         61     61           

@X-Guardian X-Guardian marked this pull request as ready for review June 23, 2020 16:25
@X-Guardian X-Guardian requested a review from johlju June 23, 2020 16:25
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 23, 2020
@X-Guardian
Copy link
Contributor Author

Cheers @johlju.

@X-Guardian X-Guardian merged commit 05e2e29 into dsccommunity:master Jun 23, 2020
@X-Guardian X-Guardian deleted the Pipeline-Fixes branch June 23, 2020 16:44
@X-Guardian X-Guardian removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADManagedServiceAccount: The term 'Get-LocalizedData' is not recognized
2 participants