-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveDirectoryDsc: Migrate HQRM And Unit Tests to PowerShell 7 #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johlju
added
the
waiting for author response
The pull request is waiting for the author to respond to comments in the pull request.
label
Apr 19, 2020
X-Guardian
force-pushed
the
PowerShell-7-Test
branch
from
April 19, 2020 19:10
9afe27e
to
9587eb7
Compare
X-Guardian
changed the title
ActiveDirectoryDsc: HQRM And Unit Tests - PowerShell 7 Test
ActiveDirectoryDsc: Migrate HQRM And Unit Tests to PowerShell 7
Apr 19, 2020
X-Guardian
removed
the
waiting for author response
The pull request is waiting for the author to respond to comments in the pull request.
label
Apr 19, 2020
johlju
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
@X-Guardian Awesome work! 😄 |
johlju
added
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
and removed
needs review
The pull request needs a code review.
labels
Apr 21, 2020
johlju
removed
the
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
label
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR migrates the HQRM and Unit Tests to using PowerShell 7 in the CI. This is to avoid this PowerShell performance issue with Pester: pester/Pester#1318.
This reduces the runtime of the Unit Tests in the CI from 45 minutes to 10 minutes.
Changes that had to be made as part of this:
Get-ByteContent
used by theADUser
resourceGet-ThumbnailByteArray
function to cope with differentGet-Content
parameters between PowerShell Desktop and Core.Compare-ResourcePropertyState
test changes to handle differences between PowerShell Desktop And Core with hashtable ordering.ActiveDirectory
stub module changes due to PowerShell Core unimplementedSecurityIdentifier
property of theSystem.Security.Principal
class.Kds
as this module will not currently import on PowerShell Core.This Pull Request (PR) fixes the following issues
None
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is