Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDomain: Add Get-ADDomain Additional Retry Exceptions #577

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Mar 7, 2020

Pull Request (PR) description

This PR adds the following additional exceptions to the retry mechanism for the Get-ADDomain cmdlet that have been shown to occur when the domain controller is initialising:

  • System.Security.Authentication.AuthenticationException
  • System.InvalidOperationException

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@X-Guardian X-Guardian marked this pull request as ready for review March 8, 2020 07:55
@X-Guardian X-Guardian added the needs review The pull request needs a code review. label Mar 8, 2020
@X-Guardian X-Guardian requested a review from johlju March 8, 2020 07:55
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit ff7d92f into dsccommunity:master Mar 9, 2020
@johlju johlju removed the needs review The pull request needs a code review. label Mar 9, 2020
@X-Guardian X-Guardian deleted the ADDomain-Add-Get-ADDomain-Retry-Exceptions branch April 7, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants