Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADObjectPermissionEntry: Fix AD PSDrive Scope Issue #565

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

shurick81
Copy link
Contributor

@shurick81 shurick81 commented Feb 8, 2020

Pull Request (PR) description

This PR solves the issue with the ADObjectPermissionEntry resource where the AD PSDrive needs to be created but it is in the wrong scope..

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@shurick81 shurick81 changed the title Patch 1 Fixing #547, ADObjectPermissionEntry Feb 8, 2020
@X-Guardian X-Guardian changed the title Fixing #547, ADObjectPermissionEntry ADObjectPermissionEntry: Fix AD PSDrive Scope Issue Feb 8, 2020
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0c5a618). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #565   +/-   ##
=========================================
  Coverage          ?   98.86%           
=========================================
  Files             ?       23           
  Lines             ?     3074           
  Branches          ?        0           
=========================================
  Hits              ?     3039           
  Misses            ?       35           
  Partials          ?        0
Impacted Files Coverage Δ
...DirectoryDsc.Common/ActiveDirectoryDsc.Common.psm1 99.02% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5a618...179549a. Read the comment docs.

Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian X-Guardian merged commit 32bae66 into dsccommunity:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADObjectPermissionEntry: Cannot find drive. A drive with the name 'AD' does not exist
2 participants