Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Update License Copyright to Dsc Community Contributors #557

Merged
merged 4 commits into from
Feb 5, 2020
Merged

ActiveDirectoryDsc: Update License Copyright to Dsc Community Contributors #557

merged 4 commits into from
Feb 5, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Feb 5, 2020 •
edited
Loading

Pull Request (PR) description

This PR updates the license copyright from Copyright (c) 2015 Microsoft Corporation. to Copyright (c) DSC Community contributors.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@X-Guardian X-Guardian requested a review from johlju February 5, 2020 12:21
@X-Guardian X-Guardian added the needs review The pull request needs a code review. label Feb 5, 2020
johlju
johlju approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

johlju
johlju approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian X-Guardian merged commit 1626c18 into dsccommunity:master Feb 5, 2020
@X-Guardian X-Guardian deleted the ActiveDirectoryDsc-Fix-License branch February 5, 2020 20:17
@X-Guardian X-Guardian removed the needs review The pull request needs a code review. label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should update the LICENSE copyright
2 participants
@X-Guardian @johlju