-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveDirectoryDsc: Fix more hashtables according to styleguideline #523
Conversation
- Fix hashtables according to style guideline (issue dsccommunity#516).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions
Tests/Unit/MSFT_ADKDSKey.Tests.ps1, line 599 at r1 (raw file):
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value
Should be split.
Tests/Unit/MSFT_ADManagedServiceAccount.Tests.ps1, line 951 at r1 (raw file):
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value
Should be split. Throughout.
Codecov Report
@@ Coverage Diff @@
## dev #523 +/- ##
====================================
+ Coverage 98% 98% +<1%
====================================
Files 23 23
Lines 3163 3167 +4
Branches 10 10
====================================
+ Hits 3119 3123 +4
Misses 34 34
Partials 10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @johlju)
Tests/Unit/MSFT_ADKDSKey.Tests.ps1, line 599 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value
Should be split.
Done
Tests/Unit/MSFT_ADManagedServiceAccount.Tests.ps1, line 951 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value
Should be split. Throughout.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fixes #516
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is