Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryDsc: Fix more hashtables according to styleguideline #523

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 29, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #516

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

- Fix hashtables according to style guideline (issue dsccommunity#516).
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions


Tests/Unit/MSFT_ADKDSKey.Tests.ps1, line 599 at r1 (raw file):

Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value

Should be split.


Tests/Unit/MSFT_ADManagedServiceAccount.Tests.ps1, line 951 at r1 (raw file):

Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value

Should be split. Throughout.

@codecov-io
Copy link

Codecov Report

Merging #523 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #523    +/-   ##
====================================
+ Coverage    98%    98%   +<1%     
====================================
  Files        23     23            
  Lines      3163   3167     +4     
  Branches     10     10            
====================================
+ Hits       3119   3123     +4     
  Misses       34     34            
  Partials     10     10

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @johlju)


Tests/Unit/MSFT_ADKDSKey.Tests.ps1, line 599 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value

Should be split.

Done


Tests/Unit/MSFT_ADManagedServiceAccount.Tests.ps1, line 951 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
Parameter = $incorrectParameter.Name; Value = $incorrectParameter.Value

Should be split. Throughout.

Done

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit bde63e2 into dsccommunity:dev Oct 29, 2019
@johlju johlju deleted the fix-hashtables branch October 29, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveDirectoryDsc: Resolve style guideline violations for hashtables
2 participants