Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for resource that uses RestoreFromRecycleBin #499

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 3, 2019

Pull Request (PR) description

  • Changes to ADUser
    • Added a note to the resource README.md that RestoreFromRecycleBin
      needs the feature Recycle Bin enabled.
  • Changes to ADGroup
  • Changes to ADOrganizationalUnit
    • Added a note to the resource README.md that RestoreFromRecycleBin
      needs the feature Recycle Bin enabled.
  • Changes to ADComputer
    • Added a note to the resource README.md that RestoreFromRecycleBin
      needs the feature Recycle Bin enabled (issue ADComputer: Not restoring deleted object #498).
    • Updated integration test to be able to catch when a computer account
      cannot be restored.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Sep 3, 2019
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Sep 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #499 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #499   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        23     23           
  Lines      3086   3086           
  Branches     10     10           
===================================
  Hits       3041   3041           
  Misses       35     35           
  Partials     10     10

@johlju johlju merged commit ae42a2c into dsccommunity:dev Sep 3, 2019
@johlju johlju deleted the fix-issue-496 branch September 3, 2019 16:19
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADComputer: Not restoring deleted object ADGroup: Not restoring deleted object
2 participants