Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADGroup: Add integration tests #495

Merged
merged 2 commits into from
Sep 1, 2019
Merged

ADGroup: Add integration tests #495

merged 2 commits into from
Sep 1, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 31, 2019 •
edited by SteveL-MSFT
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju
Changes to ADGroup
ffb8794 
- Now Get-TargetResource returns correct value when the group does not
    exist.
- Added integration tests (issue dsccommunity#350).
johlju
johlju commented Aug 31, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion

Tests/Integration/MSFT_ADGroup.config.ps1, line 26 at r1 (raw file):

PsDscAllowPlainTextPassword = $true

This should be removed.

@codecov-io
Copy link

Codecov Report

Merging #495 into dev will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #495   +/-   ##
===================================
- Coverage    98%    98%   -1%     
===================================
  Files        23     23           
  Lines      3065   3061    -4     
  Branches     10     10           
===================================
- Hits       3020   3016    -4     
  Misses       35     35           
  Partials     10     10

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Aug 31, 2019
johlju
johlju commented Sep 1, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved

Tests/Integration/MSFT_ADGroup.config.ps1, line 26 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
PsDscAllowPlainTextPassword = $true

This should be removed.

Done

johlju
johlju commented Sep 1, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Sep 1, 2019
@johlju johlju merged commit 2490788 into dsccommunity:dev Sep 1, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 1, 2019
@johlju johlju deleted the add-integ-ADGroup branch September 1, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADGroup: Integration tests is missing for this resource
2 participants
@johlju @codecov-io