Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDirectoryDsc: Add stubs generated by Indented.StubCommand #483

Merged
merged 5 commits into from
Aug 21, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 12, 2019

Pull Request (PR) description

  • Changes to ActiveDirectoryDsc
    • Added new stubs for the cmdlets and classes to be used with unit tests.
      The new stubs are based on the modules ActiveDirectory and ADDSDeployment
      in Windows Server 2019. The stubs are generated using the PowerShell
      module Indented.StubCommand. Instructions how to generate stubs
      (for example for a new operating system) has been added to the README.md
      in the Tests/Unit/Stubs folder (issue #245).
    • Update all unit tests removing all local stub functions in favor of
      the new stub modules.
    • Changes to ActiveDirectoryDsc.Common.
      • Updated the function Test-ADReplicationSite to make the parameter
        Credential mandatory.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the on hold The issue or pull request has been put on hold by a maintainer. label Aug 12, 2019
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #483 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #483   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        23     23           
  Lines      3050   3050           
  Branches     10     10           
===================================
  Hits       3008   3008           
  Misses       32     32           
  Partials     10     10

@johlju
Copy link
Member Author

johlju commented Aug 12, 2019

Waiting for the proposed PR indented-automation/Indented.StubCommand#21 to be merged since that is a prerequisites for this change.

@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Aug 13, 2019
@johlju johlju force-pushed the add-stubs branch 2 times, most recently from c6e6387 to 8d17f0b Compare August 19, 2019 16:09
johlju added 5 commits August 20, 2019 17:36
- Added stubs for the modules ActiveDirectory and ADDSDeployment to be used with unit tests.
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 28 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 9d5cf86 into dsccommunity:dev Aug 21, 2019
@johlju johlju deleted the add-stubs branch August 21, 2019 15:59
@johlju johlju removed the needs review The pull request needs a code review. label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveDirectoryDsc: Add stubs to be used with unit tests
2 participants