Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADUser: Uses helper function Add-TypeAssembly #458

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 2, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 2, 2019
@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #458 into dev will decrease coverage by <1%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #458   +/-   ##
===================================
- Coverage    98%    98%   -1%     
===================================
  Files        20     20           
  Lines      2815   2816    +1     
  Branches     10     10           
===================================
  Hits       2767   2767           
- Misses       38     39    +1     
  Partials     10     10

- Now uses the helper function `Add-TypeAssembly` which have some benefit
  instead of directly using `Add-Type`, like verbose logging (issue dsccommunity#431).
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit c2c504f into dsccommunity:dev Aug 3, 2019
@johlju johlju deleted the fix-issue-431 branch August 3, 2019 10:41
@johlju johlju removed the needs review The pull request needs a code review. label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADUser: Use helper function Add-TypeAssembly
2 participants