Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: ADDomain: Add new parameter AllowTrustRecreation #457

Merged
merged 4 commits into from
Aug 3, 2019
Merged

BREAKING CHANGE: ADDomain: Add new parameter AllowTrustRecreation #457

merged 4 commits into from
Aug 3, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 2, 2019 •
edited by SteveL-MSFT
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. help wanted The issue is up for grabs for anyone in the community. labels Aug 2, 2019
@codecov-io
Copy link

codecov-io commented Aug 2, 2019 •
edited
Loading

Codecov Report

Merging #457 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #457    +/-   ##
====================================
+ Coverage    98%    98%   +<1%     
====================================
  Files        20     20            
  Lines      2816   2823     +7     
  Branches     10     10            
====================================
+ Hits       2767   2774     +7     
  Misses       39     39            
  Partials     10     10

@johlju johlju added needs review The pull request needs a code review. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 2, 2019
@johlju johlju force-pushed the fix-issue-421 branch 2 times, most recently from c52ae97 to b293b58 Compare August 3, 2019 08:02
johlju
johlju commented Aug 3, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion

Examples/Resources/ADDomainTrust/2-ADDomainTrust_ExternalInboundTrustWithOptInToRecreate_Config.ps1, line 3 at r2 (raw file):

2caf2b93-d87e-426d-8c44-9f1d0452be10

Must change to a new guid, since it is duplicate with the other example

johlju added 4 commits August 3, 2019 20:25
@johlju
Changes to ADDomain
2c54137 
- BREAKING CHANGE: A new parameter `AllowTrustRecreation` has been added
  that when set allows a trust to be recreated in scenarios where that
  is required. This way the user have to opt-in to such destructive
  action since since it can result in service interruption (issue dsccommunity#421).
@johlju
Update examples
7face90
@johlju
Update help.txt
9dab36a
@johlju
Fix review comment at r1
3960f96
johlju
johlju commented Aug 3, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on @johlju)

Examples/Resources/ADDomainTrust/2-ADDomainTrust_ExternalInboundTrustWithOptInToRecreate_Config.ps1, line 3 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
2caf2b93-d87e-426d-8c44-9f1d0452be10

Must change to a new guid, since it is duplicate with the other example

Done

johlju
johlju commented Aug 3, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 2922053 into dsccommunity:dev Aug 3, 2019
@johlju johlju deleted the fix-issue-421 branch August 3, 2019 18:40
@johlju johlju removed the needs review The pull request needs a code review. label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADDomainTrust: Add 'AllowTrustRecreation' property to opt-in to allow trust recreation
2 participants
@johlju @codecov-io