Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #445

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Update CHANGELOG.md #445

merged 1 commit into from
Jul 22, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 22, 2019

Pull Request (PR) description

  • Rearrange entries in the the change log.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Rearrange entries in the the change log.
@johlju johlju added the needs review The pull request needs a code review. label Jul 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #445 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #445   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        20     20           
  Lines      2704   2704           
  Branches     10     10           
===================================
  Hits       2607   2607           
  Misses       87     87           
  Partials     10     10

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 919237a into dev Jul 22, 2019
@johlju johlju deleted the johlju-patch-1 branch July 22, 2019 09:35
@johlju johlju removed the needs review The pull request needs a code review. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants