xADOrganizationalUnit: Catch Exception When the Path Property specifies a Non-Existing Path

[X-Guardian]

Pull Request (PR) description

This PR adds code to the xADOrganizationalUnit resource to catch the ADIdentityNotFoundException returned by Get-ADOrganizationalUnit and return an improved error message.

This Pull Request (PR) fixes the following issues

• Fixes xADOrganizationalUnit: Unhandled Exception when the Path Property specifies a Non-Existing Path #408

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in resource directory README.md.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #413 into dev will increase coverage by <1%.
The diff coverage is 80%.

@@         Coverage Diff          @@
##            dev   #413    +/-   ##
====================================
+ Coverage    92%    92%   +<1%     
====================================
  Files        20     20            
  Lines      2538   2541     +3     
  Branches     10     10            
====================================
+ Hits       2345   2348     +3     
  Misses      183    183            
  Partials     10     10

[PlagueHO]

Reviewed 1 of 2 files at r1, 3 of 3 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @X-Guardian)

---

DSCResources/MSFT_xADOrganizationalUnit/MSFT_xADOrganizationalUnit.psm1, line 30 at r3 (raw file):

    try
    {
        $ou = Get-ADOrganizationalUnit -Filter { Name -eq $Name } -SearchBase $Path -SearchScope OneLevel -Properties ProtectedFromAccidentalDeletion, Description

Might be worth splitting this line with a backtick so that it gets in below 120 chars. Alternatively, could splat this.

[johlju]

Reviewed 1 of 2 files at r1, 2 of 3 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

---

DSCResources/MSFT_xADOrganizationalUnit/MSFT_xADOrganizationalUnit.psm1, line 30 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Might be worth splitting this line with a backtick so that it gets in below 120 chars. Alternatively, could splat this.

Yeah, spatting this would make it easier to read, especially when revewing. But won't hold the PR up because of it since it is old code. There are more places this need to be resolved. I will add an issue for this. The local variable could also be more descriptive, also another PR. 🙂

[johlju]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)