Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Add Missing Resource Examples #397

Merged
merged 4 commits into from
Jun 26, 2019
Merged

xActiveDirectory: Add Missing Resource Examples #397

merged 4 commits into from
Jun 26, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 25, 2019

Pull Request (PR) description

This PR adds examples for the following resources that were missing:

  • xADReplicationSubnet
  • xADServicePrincipalName
  • xWaitForADDomain

It also adds links to these on the example README.md as well as xADObjectEnabledState which was missing from a previous update.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@7fb5aa7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##             dev   #397   +/-   ##
====================================
  Coverage       ?    92%           
====================================
  Files          ?     20           
  Lines          ?   2538           
  Branches       ?     10           
====================================
  Hits           ?   2345           
  Misses         ?    183           
  Partials       ?     10

@X-Guardian X-Guardian marked this pull request as ready for review June 25, 2019 22:04
@johlju johlju added the needs review The pull request needs a code review. label Jun 26, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jun 26, 2019
@johlju johlju merged commit 46634ed into dsccommunity:dev Jun 26, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 26, 2019
@X-Guardian
Copy link
Contributor Author

Cheers @johlju. Don't forget to update the Wiki.

(Now if only there was a way that we could do this automatically... 😉)

@johlju
Copy link
Member

johlju commented Jun 26, 2019

There is a release coming any day now so I wait until then. :)

@X-Guardian X-Guardian deleted the xActiveDirectory-Add-Missing-Examples branch June 27, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xActiveDirectory: Some Resources are missing examples
3 participants