Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xADOrganizationalUnit: Verbose Message Fix #396

Merged
merged 2 commits into from
Jun 26, 2019
Merged

xADOrganizationalUnit: Verbose Message Fix #396

merged 2 commits into from
Jun 26, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 25, 2019

Pull Request (PR) description

This PR fixes the incorrect verbose message when this resource has Ensure set to Absent.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #396 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #396   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2538   2538           
  Branches     10     10           
===================================
  Hits       2345   2345           
  Misses      183    183           
  Partials     10     10

@X-Guardian X-Guardian changed the title xOrganizationalUnit: Verbose message fix xADOrganizationalUnit: Verbose Message Fix Jun 25, 2019
@X-Guardian X-Guardian marked this pull request as ready for review June 25, 2019 20:06
@johlju johlju added the needs review The pull request needs a code review. label Jun 26, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 7fb5aa7 into dsccommunity:dev Jun 26, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jun 26, 2019
@X-Guardian X-Guardian deleted the xADOrganizationalUnit-Verbose-Message-Fix branch June 27, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xADOrganizationalUnit: Test-TargetResource showing wrong verbose message
3 participants