-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xADRecycleBin: Replace Write-Error with the correct helper function #393
xADRecycleBin: Replace Write-Error with the correct helper function #393
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #393 +/- ##
===================================
Coverage 92% 92%
===================================
Files 20 20
Lines 2538 2538
Branches 10 10
===================================
Hits 2345 2345
Misses 183 183
Partials 10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @X-Guardian)
CHANGELOG.md, line 118 at r3 (raw file):
- Replace Write-Error with the correct helper function.
Can we reference the issue here?
Whoops, yes I forgot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. 😃
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This PR replaces the
Write-Error
statements in thexADRecycleBin
resource with calls to the relevant resource helper exception functions.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is