Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xADRecycleBin: Replace Write-Error with the correct helper function #393

Merged
merged 7 commits into from
Jun 25, 2019
Merged

xADRecycleBin: Replace Write-Error with the correct helper function #393

merged 7 commits into from
Jun 25, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 24, 2019

Pull Request (PR) description

This PR replaces the Write-Error statements in the xADRecycleBin resource with calls to the relevant resource helper exception functions.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 24, 2019

Codecov Report

Merging #393 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #393   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2538   2538           
  Branches     10     10           
===================================
  Hits       2345   2345           
  Misses      183    183           
  Partials     10     10

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 25, 2019
@X-Guardian X-Guardian marked this pull request as ready for review June 25, 2019 08:59
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jun 25, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @X-Guardian)


CHANGELOG.md, line 118 at r3 (raw file):

  - Replace Write-Error with the correct helper function.

Can we reference the issue here?

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jun 25, 2019
@X-Guardian
Copy link
Contributor Author

Whoops, yes I forgot.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

No worries. 😃

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jun 25, 2019
@johlju johlju merged commit 5916dca into dsccommunity:dev Jun 25, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 25, 2019
@X-Guardian X-Guardian deleted the xADRecycleBin-Write-Error-Fix branch June 25, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xADRecycleBin: Replace Write-Error with the correct helper function
3 participants