Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xADUser: Fix Password Property Being Updated Whenever Another Property is Changed #389

Merged
merged 4 commits into from
Jun 23, 2019
Merged

xADUser: Fix Password Property Being Updated Whenever Another Property is Changed #389

merged 4 commits into from
Jun 23, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 23, 2019

Pull Request (PR) description

This PR fixes the issue that Password property is being updated whenever another property is changed even though it was already in the desired state.

This is achieved by adding a call to the Test-Password function from within the relevant code block of the Set-TargetResource function.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 23, 2019

Codecov Report

Merging #389 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #389    +/-   ##
====================================
+ Coverage    92%    92%   +<1%     
====================================
  Files        20     20            
  Lines      2530   2538     +8     
  Branches     10     10            
====================================
+ Hits       2335   2343     +8     
  Misses      185    185            
  Partials     10     10

@X-Guardian X-Guardian marked this pull request as ready for review June 23, 2019 15:27
@johlju johlju added the needs review The pull request needs a code review. label Jun 23, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Awesome work! 😃

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jun 23, 2019
@johlju johlju merged commit f664c1f into dsccommunity:dev Jun 23, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 23, 2019
@X-Guardian X-Guardian deleted the xADUser-Password-Update-Fix branch June 23, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xADUser: Password Property is Updated Whenever Another Property is Changed
3 participants