Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xADComputer: Fix ServicePrincipalNames Empty String Exception #388

Merged
merged 3 commits into from
Jun 23, 2019
Merged

xADComputer: Fix ServicePrincipalNames Empty String Exception #388

merged 3 commits into from
Jun 23, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 23, 2019

Pull Request (PR) description

This PR fixes the Exception that occurs when the ServicePrincipalNames property is set to an empty string and is not in the desired state.

Additional tests have been added to test all properties being set to empty strings.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #388 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #388   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2530   2530           
  Branches     10     10           
===================================
  Hits       2335   2335           
  Misses      185    185           
  Partials     10     10

@X-Guardian X-Guardian marked this pull request as ready for review June 23, 2019 14:22
@johlju johlju added the needs review The pull request needs a code review. label Jun 23, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 061ca89 into dsccommunity:dev Jun 23, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jun 23, 2019
@X-Guardian X-Guardian deleted the xADComputer-SPN-Empty-String-Fix branch June 23, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xADComputer: Exception When Setting ServicePrincipalNames to An Empty String
3 participants