xActiveDirectory: Use fully qualified type names

[johlju]

Pull Request (PR) description

• Changes to xActiveDirectory
  • Cleanup of code
    • Use fully qualified type names for parameters and variables
      (issue xActiveDirectory: Use fully qualified type names for parameters and variables #374).

Also updated the examples a bit, that should already be covered by another change log entry.

This Pull Request (PR) fixes the following issues

• Fixes xActiveDirectory: Use fully qualified type names for parameters and variables #374

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in resource directory README.md.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #385 into dev will not change coverage.
The diff coverage is 83%.

@@         Coverage Diff         @@
##            dev   #385   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2530   2530           
  Branches     10     10           
===================================
  Hits       2335   2335           
  Misses      185    185           
  Partials     10     10

[johlju]

@PlagueHO Could you review this when you have time. A lot of files, but I think this one will be easy reviewed anyway. 🙂

[PlagueHO]

Of course @johlju - I'm on it.

[PlagueHO]

Just a couple of minor tweaks. But awesome job!

Reviewed 43 of 44 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johlju)

---

Examples/Resources/xADUser/1-CreateUserAndManagePassword_Config.ps1, line 43 at r2 (raw file):

        {
            Ensure     = 'Present'
            UserName   = "ExampleUser"

Strings should be single quoted (and next few).

---

Examples/Resources/xADUser/2-CreateUserAndIgnorePasswordChanges_Config.ps1, line 44 at r2 (raw file):

        {
            Ensure              = 'Present'
            UserName            = "ExampleUser"

Strings should be single quoted (and next few).

---

Tests/Unit/MSFT_xADGroup.Tests.ps1, line 450 at r2 (raw file):

                Mock -CommandName Get-DomainName -MockWith {return 'contoso.com'}
                Mock -CommandName Get-ADDomainNameFromDistinguishedName -MockWith {
                    param (

( should be on next line

[johlju]

I formatted the parameters of some stub functions. I did not add [Parameter()] to them on purpose, I would rather we solved having a module with stubs so they could be removed entirely.

Reviewable status: 40 of 50 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

---

Examples/Resources/xADUser/1-CreateUserAndManagePassword_Config.ps1, line 43 at r2 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Strings should be single quoted (and next few).

Done.

---

Examples/Resources/xADUser/2-CreateUserAndIgnorePasswordChanges_Config.ps1, line 44 at r2 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Strings should be single quoted (and next few).

Done.

---

Tests/Unit/MSFT_xADGroup.Tests.ps1, line 450 at r2 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

( should be on next line

Done. Fix all in the repo.

[PlagueHO]

Reviewed 10 of 10 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

@PlagueHO Thanks for the review! This one is starting to get closer and closer for a rename.