xADUser: Add Additional Parameters

[X-Guardian]

Pull Request (PR) description

This PR adds the following parameters to the xADUser resource:

• AccountNotDelegated
• AllowReversiblePasswordEncryption
• CompoundIdentitySupported
• PasswordNotRequired
• SmartcardLogonRequired
• LogonWorkstations
• Organization
• OtherName

These are all the remaining String and Boolean parameters available in the New/Get/Set-ADUser PowerShell cmdlets.

This Pull Request (PR) partly fixes the following issues

None

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #373 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #373    +/-   ##
====================================
+ Coverage    92%    92%   +<1%     
====================================
  Files        20     20            
  Lines      2512   2531    +19     
  Branches     10     10            
====================================
+ Hits       2313   2333    +20     
+ Misses      189    188     -1     
  Partials     10     10

[johlju]

@X-Guardian Can you please look at rebasing this, you got a lot of files that has already been merged (see for example commit ec1f69e).

[X-Guardian]

Done. (forgot to force push)

[johlju]

Looks good. I will wait for you to rebase until merging.

Reviewed 4 of 4 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

[X-Guardian]

Did you see my message on #371. Shall we get that sorted first?

[johlju]

Yes I saw that comment after I reviewed this PR (lot of community e-mails in the backlog :) )
It does not matter what order we merge, merge this or merge a new PR that fixes the issue in #371.
Work on the one you want to merge first :)

[johlju]

Merged the other one, and I added latest changes to this PR.

[X-Guardian]

This one could do with another test. Hang fire on merging till I add it.

[johlju]

Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @X-Guardian)

---

Tests/Unit/MSFT_xADUser.Tests.ps1, line 68 at r3 (raw file):

'ChangePasswordAtLogon'

I think this property was wrongly removed from $testBooleanProperties?

[johlju]

@X-Guardian ah, then make sure to rebase in latest changes to your PR and force push so this matches your local branch (since I asked GitHub GUI to merge in dev-branch). 😃

[X-Guardian]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johlju)

---

Tests/Unit/MSFT_xADUser.Tests.ps1, line 68 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

'ChangePasswordAtLogon'

I think this property was wrongly removed from $testBooleanProperties?

Yep, I've added it back.

[johlju]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved