Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Add Missing and Fix Wiki Corruption Causing Schema Descriptions #370

Merged
merged 6 commits into from
Jun 15, 2019
Merged

xActiveDirectory: Add Missing and Fix Wiki Corruption Causing Schema Descriptions #370

merged 6 commits into from
Jun 15, 2019

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Jun 13, 2019

Pull Request (PR) description

This PR adds missing schema descriptions to the xADRecycleBin and xWaitForADDomain resources. It also removes the { *Present* | Absent }. string from the xADReplicationSubnet and xADServicePrincipalName schema descriptions which were causing corruption in the Wiki property tables for these resources.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #370 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #370   +/-   ##
===================================
  Coverage    91%    91%           
===================================
  Files        20     20           
  Lines      2383   2383           
  Branches     10     10           
===================================
  Hits       2190   2190           
  Misses      183    183           
  Partials     10     10

@johlju johlju added needs review The pull request needs a code review. waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jun 15, 2019
@X-Guardian X-Guardian marked this pull request as ready for review June 15, 2019 12:15
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jun 15, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 1aa7cc7 into dsccommunity:dev Jun 15, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jun 15, 2019
@X-Guardian X-Guardian deleted the Descriptions-Add branch June 23, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants