Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 295 #313

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix for issue 295 #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b8119
Removed unnecessary -as operator cast
May 27, 2019
38e89e3
Added changelog entries and removed cast at an additional position.
Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
- Moved examples from the README.md to separate example files in the
Examples folder.
- Fix the RestoreFromRecycleBin Description
- Fix unnecessary cast in `Test-TargetResource` ([Issue #295](https://github.com/PowerShell/xActiveDirectory/issues/295))
- Changes to xADGroup
- Change the description of the property RestoreFromRecycleBin.
- Changes to xADObjectPermissionEntry
Expand Down
4 changes: 2 additions & 2 deletions DSCResources/MSFT_xADComputer/MSFT_xADComputer.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ function Test-TargetResource
if ($PSBoundParameters.ContainsKey('ServicePrincipalNames'))
{
$testServicePrincipalNamesParameters = @{
ExistingServicePrincipalNames = $getTargetResourceResult.ServicePrincipalNames -as [System.String[]]
ExistingServicePrincipalNames = $getTargetResourceResult.ServicePrincipalNames
ServicePrincipalNames = $ServicePrincipalNames
}

Expand Down Expand Up @@ -842,7 +842,7 @@ function Set-TargetResource
if ($PSBoundParameters.ContainsKey('ServicePrincipalNames'))
{
$testServicePrincipalNamesParameters = @{
ExistingServicePrincipalNames = $getTargetResourceResult.ServicePrincipalNames -as [System.String[]]
ExistingServicePrincipalNames = $getTargetResourceResult.ServicePrincipalNames
ServicePrincipalNames = $ServicePrincipalNames
}

Expand Down