Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Fix RestoreFromRecycleBin description #308

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

SSvilen
Copy link
Contributor

@SSvilen SSvilen commented Jun 1, 2019

Pull Request (PR) description

Fix RestoreFromRecycleBin description for xADComputer and xADGroup

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #308 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #308   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2299   2299           
  Branches     10     10           
===================================
  Hits       2135   2135           
  Misses      154    154           
  Partials     10     10

@johlju johlju added the needs review The pull request needs a code review. label Jun 2, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 6222669 into dsccommunity:dev Jun 2, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jun 2, 2019
@johlju
Copy link
Member

johlju commented Jun 2, 2019

@SSvilen Thank you for this!

@SSvilen SSvilen deleted the FixRestoreDescriptions branch June 2, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants