Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Opt-In to DSC Resource Common Meta Tests #306

Merged
merged 10 commits into from
Jun 2, 2019
5 changes: 5 additions & 0 deletions .MetaTestOptIn.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
[
"Common Tests - Validate Module Files",
"Common Tests - Validate Markdown Files",
"Common Tests - Validate Script Files",
"Common Tests - Relative Path Length",
"Common Tests - Validate Markdown Links",
"Common Tests - Validate Markdown Files",
"Common Tests - Custom Script Analyzer Rules",
"Common Tests - Required Script Analyzer Rules",
Expand Down
11 changes: 8 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,14 @@
- Test-DscPropertyState
- Move the examples in the README.md to Examples folder
- Fix Script Analyzer rule failures
- Opt-in to "Common Tests - Custom Script Analyzer Rules"
- Opt-in to "Common Tests - Required Script Analyzer Rules"
- Opt-in to "Common Tests - Flagged Script Analyzer Rules"
- Opt-in to the following DSC Resource Common Meta Tests:
- Common Tests - Custom Script Analyzer Rules
- Common Tests - Required Script Analyzer Rules
- Common Tests - Flagged Script Analyzer Rules
- Common Tests - Validate Module Files ([Issue #282](https://github.com/PowerShell/xActiveDirectory/issues/282))
- Common Tests - Validate Script Files ([Issue #283](https://github.com/PowerShell/xActiveDirectory/issues/283))
- Common Tests - Relative Path Length ([Issue #284](https://github.com/PowerShell/xActiveDirectory/issues/284))
- Common Tests - Validate Markdown Links ([Issue #280](https://github.com/PowerShell/xActiveDirectory/issues/280))
- Changes to xADComputer
- Refactored the resource and the unit tests.
- BREAKING CHANGE: The `Enabled` property is **DEPRECATED** and is no
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Import the common AD functions
## Import the common AD functions
$adCommonFunctions = Join-Path `
-Path (Split-Path -Path $PSScriptRoot -Parent) `
-ChildPath '\MSFT_xADCommon\MSFT_xADCommon.psm1'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:resourceModulePath = Split-Path -Path (Split-Path -Path $PSScriptRoot -Parent) -Parent
$script:modulesFolderPath = Join-Path -Path $script:resourceModulePath -ChildPath 'Modules'

$script:localizationModulePath = Join-Path -Path $script:modulesFolderPath -ChildPath 'xActiveDirectory.Common'
Expand Down
6 changes: 3 additions & 3 deletions Examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ xActiveDirectory resource module.

These are the links to the examples for each individual resource.

- [xADComputer](/Examples/Resources/xADComputer)
- [xADObjectPermissionEntry](/Examples/Resources/xADObjectPermissionEntry)
- [xADUser](/Examples/Resources/xADUser)
- [xADComputer](Resources/xADComputer)
- [xADObjectPermissionEntry](Resources/xADObjectPermissionEntry)
- [xADUser](Resources/xADUser)