Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xADObjectEnabledState: New resource #277

Merged
merged 9 commits into from
Jun 15, 2019
Merged

xADObjectEnabledState: New resource #277

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2cd797a
Add new resource xADObjectEnabledState
johlju May 22, 2019
2e41fe4
Add resource README.md
johlju Jun 4, 2019
69cf005
Fix examples
johlju Jun 4, 2019
66bbe93
Fix typo in example
johlju Jun 4, 2019
f639855
Remove unnecessary localized string
johlju Jun 4, 2019
d19db0e
Add Compare-TargetResourceState
johlju Jun 4, 2019
4b5e7b5
Remove OrderNumber from integration tests
johlju Jun 5, 2019
6a72208
Move Set-DscADComputer as a helper function
johlju Jun 7, 2019
fc7931e
Merge branch 'dev' into add-xADObjectEnabledState
johlju Jun 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
are not in desired state when verbose output is enabled.
- Update all unit tests to latest unit test template.
- Deleted the obsolete xActiveDirectory_TechNetDocumentation.html file
- Added new resource xADObjectEnabledState. This resource should be
used to enforce the `Enabled` property of computer accounts. This
resource replaces the deprecated `Enabled` property in the resource
xADComputer.
- Changes to xADComputer
- Refactored the resource and the unit tests.
- BREAKING CHANGE: The `Enabled` property is **DEPRECATED** and is no
Expand Down
24 changes: 0 additions & 24 deletions DSCResources/MSFT_xADComputer/MSFT_xADComputer.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,30 +950,6 @@ function Set-TargetResource
}
}

<#
.SYNOPSIS
This is a wrapper for Set-ADComputer.

.PARAMETER Parameters
A hash table containing all parameters that will be passed trough to
Set-ADComputer.

.NOTES
This is needed because of how Pester is unable to handle mocking the
cmdlet Set-ADComputer.
#>
function Set-DscADComputer
{
param
(
[Parameter(Mandatory = $true)]
[System.Collections.Hashtable]
$Parameters
)

Set-ADComputer @Parameters | Out-Null
}

<#
.SYNOPSIS
This evaluates the service principal names current state against the
Expand Down
Loading