-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xADObjectPermissionEntry: Using more generic "AD:" to prevent errors #243
Conversation
Merging release pull request
Merging release pull request
Release of version 2.12.0.0 of xActiveDirectory
Merging release pull request
Merging release pull request
Merging release pull request
Merging release pull request
Release of version 2.17.0.0 of xActiveDirectory
Release of version 2.18.0.0 of xActiveDirectory
Release of version 2.19.0.0 of xActiveDirectory
Release of version 2.20.0.0 of xActiveDirectory
Release of version 2.21.0.0 of xActiveDirectory
Release of version 2.22.0.0 of xActiveDirectory
Release of version 2.23.0.0 of xActiveDirectory
Release of version 2.24.0.0 of xActiveDirectory
Codecov Report
@@ Coverage Diff @@
## dev #243 +/- ##
===================================
Coverage 85% 85%
===================================
Files 18 18
Lines 1553 1553
Branches 10 10
===================================
Hits 1324 1324
Misses 219 219
Partials 10 10 |
@DennisGaida looks good, are you okay to rebase and update? |
I updated the PR with the latest changes from the dev branch |
I just merged a PR that fixes the problem with the tests failing. Please rebase this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! 😄 Just two review comments.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DennisGaida)
a discussion (no related file):
Could you please update the unreleased section under the change log in the file README.md.
a discussion (no related file):
Please make the same change in the unit test (replacing Microsoft.ActiveDirectory.Management\ActiveDirectory:://RootDSE
):
https://github.com/PowerShell/xActiveDirectory/blob/dev/Tests/Unit/MSFT_xADObjectPermissionEntry.Tests.ps1
* Updated Test for xADObjectPermissionEntry with `AD:`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @johlju)
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Could you please update the unreleased section under the change log in the file README.md.
Done.
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Please make the same change in the unit test (replacing
Microsoft.ActiveDirectory.Management\ActiveDirectory:://RootDSE
):
https://github.com/PowerShell/xActiveDirectory/blob/dev/Tests/Unit/MSFT_xADObjectPermissionEntry.Tests.ps1
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
@DennisGaida Thanks for this! |
…sccommunity#243) - Updated xADObjectPermissionEntry to use `AD:` which is more generic when using `Get-Acl` and `Set-Acl` than using `Microsoft.ActiveDirectory.Management\ActiveDirectory:://RootDSE/`
As described in #236
Pull Request (PR) description
Using
AD:
is more generic than the currently usedMicrosoft.ActiveDirectory.Management\ActiveDirectory:://RootDSE/$Path
which doesn't work on all machines (sometimes a.dll
is added). UsingAD:
instead solves this problem.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is