Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX for Issue #152 #174

Closed
wants to merge 9 commits into from
Closed

FIX for Issue #152 #174

wants to merge 9 commits into from

Conversation

RobBiddle
Copy link

@RobBiddle RobBiddle commented Dec 21, 2017

Fix for this issue: #152

Functionality of xADGroup is only changed when setting Property 'MembershipAttribute' with a value of 'DistinguishedName'.

When 'DistinguishedName' is used, each Group Member DN String is evaluated to determine the AD Domain of the Group Member Object and the ObjectClass. Then Get-ADComputer,Get-ADGroup or Get-ADUser is called, specifying the appropriate Domain to query. Once the Object is retrieved then Add-ADGroupMember is able to successfully add the members, even if they exist in another domain.


This change is Reviewable

kwirkykat and others added 9 commits March 30, 2016 15:01
Release of version 2.12.0.0 of xActiveDirectory
…up membership consisting of AD Objects from multiple AD Domains.

When using a MembershipAttribute of DistinguishedName the Member Objects will now be properly obtained from the Objects' Domain rather than the Domain of the AD Group.
@johlju johlju added the needs review The pull request needs a code review. label Apr 20, 2018
@johlju
Copy link
Member

johlju commented Apr 21, 2018

@RobBiddle Sorry that it took so long to review you PR. Could you please add unit tests that tests this change?

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Apr 21, 2018
@johlju
Copy link
Member

johlju commented May 23, 2018

Labeling as abandoned since it has gone 14 days until last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 23, 2018
@nyanhp
Copy link
Contributor

nyanhp commented Feb 19, 2019

Hi @johlju , how can I continue the PR? My customer has the same requirement.

I have taken all changes from @RobBiddle and added the necessary test cases here: https://github.com/nyanhp/xActiveDirectory/tree/multidomainmembers
I have of course branched off the current dev branch.

@johlju
Copy link
Member

johlju commented Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants