-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX for Issue #152 #174
FIX for Issue #152 #174
Conversation
Merging release pull request
Merging release pull request
Release of version 2.12.0.0 of xActiveDirectory
Merging release pull request
Merging release pull request
Merging release pull request
Merging release pull request
…up membership consisting of AD Objects from multiple AD Domains. When using a MembershipAttribute of DistinguishedName the Member Objects will now be properly obtained from the Objects' Domain rather than the Domain of the AD Group.
@RobBiddle Sorry that it took so long to review you PR. Could you please add unit tests that tests this change? |
Labeling as abandoned since it has gone 14 days until last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
Hi @johlju , how can I continue the PR? My customer has the same requirement. I have taken all changes from @RobBiddle and added the necessary test cases here: https://github.com/nyanhp/xActiveDirectory/tree/multidomainmembers |
You can send in another PR. Reference this PR |
Fix for this issue: #152
Functionality of xADGroup is only changed when setting Property 'MembershipAttribute' with a value of 'DistinguishedName'.
When 'DistinguishedName' is used, each Group Member DN String is evaluated to determine the AD Domain of the Group Member Object and the ObjectClass. Then Get-ADComputer,Get-ADGroup or Get-ADUser is called, specifying the appropriate Domain to query. Once the Object is retrieved then Add-ADGroupMember is able to successfully add the members, even if they exist in another domain.
This change is