Duplicate of Abandoned PR #101: Handle FaultException race condition during domain creation & reboots. (Fixes #73) #137
Conversation
kwirkykat
changed the title
| [Parameter(Mandatory)] | ||
| [String] $DomainName | ||
| ) | ||
| Join-Path $Env:TEMP ('{0}.xADDomain.completed' -f $DomainName) |
There was a problem hiding this comment.
should this be in temp or the resource cache? Resource cache is automatically cleared when a configuration is updated. Temp of course is not.
There was a problem hiding this comment.
I have left it as temp because if the resource is called again and a domain promotion has already occurred, the resource should not attempt to promote the machine to a domain controller again. The second attempt to promote the domain controller would throw the same error this code is trying to fix.
I have added a comment to the code explaining this and providing the resource cache location if it is needed in the future.
| if($domainShouldExist) { | ||
| $retries++ | ||
| Write-Verbose ($localizedData.RetryingGetADDomain -f $retries, $maxRetries, $retryIntervalInSeconds) | ||
| Sleep -Seconds ($retries * $retryIntervalInSeconds) |
| @@ -245,6 +245,8 @@ Setting an ODJ Request file path for a configuration that creates a computer acc | |||
| ### Unreleased | |||
|
|
|||
| * xAdDomainController: Update to complete fix for SiteName being required field. | |||
| * xADDomain: Added retry logic to prevent FaultException to crash in Get-TargetResource on subsequent reboots after a domain is created because the service is not yet running. This error is mostly occur when the resource is used with the DSCExtension on Azure. | |||
There was a problem hiding this comment.
Either add tests or add an issue to follow up
There was a problem hiding this comment.
Since multiple contributors in #73 have confirmed that this fix works, I will skip adding tests for now and open an issue to add tests for this fix later.
This is the same code that was submitted by @slapointe in #101 with the merge conflicts in the README fixed.
Azure is asking for these fixes for one of their templates that the DSC extension uses.
@TravisEz13 What tests are needed for this PR to go through?
This change is