Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDomain: Add ability to specify DomainType to support TreeDomain use cases #689

Closed
rhys96 opened this issue May 18, 2022 · 2 comments · Fixed by #705
Closed

ADDomain: Add ability to specify DomainType to support TreeDomain use cases #689

rhys96 opened this issue May 18, 2022 · 2 comments · Fixed by #705
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@rhys96
Copy link

rhys96 commented May 18, 2022

Problem description

To support use cases where a regional domain acts as a forest root domain (see Selecting the Forest Root Domain for more information) we need the ability to specify the DomainType separately.

Verbose logs

N/A

DSC configuration

N/A

Suggested solution

We need the ability to specify the DomainType, for example:

Configuration ADDomain_NewTreeDomain_Config
{
    param
    (
        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [System.Management.Automation.PSCredential]
        $Credential,

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [System.Management.Automation.PSCredential]
        $SafeModePassword
    )

    Import-DscResource -ModuleName PSDesiredStateConfiguration
    Import-DscResource -ModuleName ActiveDirectoryDsc

    node 'localhost'
    {
        WindowsFeature 'ADDS'
        {
            Name   = 'AD-Domain-Services'
            Ensure = 'Present'
        }

        WindowsFeature 'RSAT'
        {
            Name   = 'RSAT-AD-PowerShell'
            Ensure = 'Present'
        }

        ADDomain 'child'
        {
            DomainName                    = 'branch.contoso.com'
            Credential                    = $Credential
            SafemodeAdministratorPassword = $SafeModePassword
            DomainMode                    = 'WinThreshold'
            ParentDomainName              = 'hq.contoso.com'
            DomainType                    = 'TreeDomain'
        }
    }
}

Operating system the target node is running

N/A

PowerShell version and build the target node is running

N/A

ActiveDirectoryDsc version

N/A
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels May 29, 2022
@johlju
Copy link
Member

johlju commented May 29, 2022

Tagged it so that someone in the community can run with it. Looking forward to review a PR for this.

@johlju
Copy link
Member

johlju commented Jun 5, 2022

More information in #692.

Borgquite added a commit to Borgquite/ActiveDirectoryDsc that referenced this issue Feb 13, 2024
johlju pushed a commit that referenced this issue Feb 14, 2024
- ADDomain
  - Added support for creating a Tree domain via the DomainType field
    (issue #689, issue #692).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants