Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Remove helper function Test-DscParameterState #522

Closed
johlju opened this issue Oct 27, 2019 · 0 comments · Fixed by #543
Closed

ActiveDirectoryDsc: Remove helper function Test-DscParameterState #522

johlju opened this issue Oct 27, 2019 · 0 comments · Fixed by #543
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Oct 27, 2019

The helper function Test-DscParameterState is no longer used by any resource and should be removed.

The helper function Compare-ResourcePropertyState should be used for the resources in the Test-TargetResource where applicable. Some resource are already using this new helper function.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Oct 27, 2019
@X-Guardian X-Guardian mentioned this issue Jan 11, 2020
Merged
9 tasks
@X-Guardian X-Guardian added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 11, 2020
johlju pushed a commit that referenced this issue Jan 14, 2020
@X-Guardian @johlju
ActiveDirectoryDsc: Remove Unused Test-DscParameterState Common Funct…
93fed1c 
…ion (#543)

- ActiveDirectoryDsc
  - Remove unused common function Test-DscParameterState (issue #522).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
2 participants
@johlju @X-Guardian