ADReplicationSiteLink: Wrong verbose message when removing sites

[johlju]

Details of the scenario you tried and the problem that is occurring

When a site that is part of SitesExcluded is present in the sites that are set, the verbose message that should show the site being removed does not show any site name.

VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Removing sites  from site link Integration1-Integration2. (ADRSL0004)

Verbose logs showing the problem

VERBOSE: [DC01]: LCM:  [ Start  Set      ]
VERBOSE: [DC01]:                            [DSCEngine] Importing the module
C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSiteLink\MSFT_ADReplicationSiteLink.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADReplicationSiteLink]Integration_Test]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADReplicationSiteLink]Integration_Test]
VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Importing the module MSFT_ADReplicationSiteLink in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Excluded Integration3 site found in SitesIncluded. Current SitesIncluded:
Integration3, Integration2, Integration1. (ADRSL0002)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADReplicationSiteLink]Integration_Test]  in 0.5310 seconds.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]  [[ADReplicationSiteLink]Integration_Test]
VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Importing the module MSFT_ADReplicationSiteLink in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Removing sites  from site link Integration1-Integration2. (ADRSL0004)
VERBOSE: [DC01]:                            [[ADReplicationSiteLink]Integration_Test] Performing the operation "Set" on target
"CN=Integration1-Integration2,CN=IP,CN=Inter-Site Transports,CN=Sites,CN=Configuration,DC=contoso,DC=com".
VERBOSE: [DC01]: LCM:  [ End    Set      ]  [[ADReplicationSiteLink]Integration_Test]  in 1.0620 seconds.
VERBOSE: [DC01]: LCM:  [ End    Resource ]  [[ADReplicationSiteLink]Integration_Test]
VERBOSE: [DC01]: LCM:  [ End    Set      ]
VERBOSE: [DC01]: LCM:  [ End    Set      ]    in  2.4060 seconds.

Suggested solution to the issue

The parameter variable name has a typo.

https://github.com/PowerShell/ActiveDirectoryDsc/blob/0643ee581d3de1148cd5ceb68eaab15fa5bcc726/DSCResources/MSFT_ADReplicationSiteLink/MSFT_ADReplicationSiteLink.psm1#L177

Changing this to $SitesExcluded would solve the issue.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

dev