Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADReplicationSite: The value returned for RenameDefaultFirstSiteName is wrong #502

Closed
johlju opened this issue Sep 15, 2019 · 0 comments · Fixed by #501
Closed

ADReplicationSite: The value returned for RenameDefaultFirstSiteName is wrong #502

johlju opened this issue Sep 15, 2019 · 0 comments · Fixed by #501
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Sep 15, 2019

Current the value for RenameDefaultFirstSiteName is always returned as an empty string. That does not match the type in the schema.mof. This should return the value of the parameter RenameDefaultFirstSiteName (which defaults to $false).

https://github.com/PowerShell/ActiveDirectoryDsc/blob/ae42a2cb0eecb4b5f4f2abcb74edd5de58bb20a6/DSCResources/MSFT_ADReplicationSite/MSFT_ADReplicationSite.psm1#L38
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Sep 15, 2019
@1800Zeta 1800Zeta mentioned this issue Sep 16, 2019
Merged
10 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 17, 2019
johlju pushed a commit that referenced this issue Sep 20, 2019
@1800Zeta @johlju
AdReplicationSite: Adding description attribute, will create integrat…
83903b2 
…ion tests (#501)

- Changes to ADReplicationSite
  - Added 'Description' attribute parameter (issue #500).
  - Added Integration testing (issue #355).
  - Correct value returned for RenameDefaultFirstSiteName (issue #502).
@johlju johlju removed in progress The issue is being actively worked on by someone. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AdReplicationSite: Adding description attribute, will create integration tests
1 participant
@johlju