Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADRecycleBin: Need to remove ShouldProcess from code #328

Closed
johlju opened this issue Jun 7, 2019 · 7 comments · Fixed by #441
Closed

xADRecycleBin: Need to remove ShouldProcess from code #328

johlju opened this issue Jun 7, 2019 · 7 comments · Fixed by #441
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

This resource is using a non-supported function. Best practices are to not use ShouldProcess in DSC resources since DSC does not support that interactive function.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jun 7, 2019
@kungfoome
Copy link

This looks like there is no Ensure parameter. @johlju Would you agree to just remove the shouldprocess binding and add in ensure to enable/disable?

@johlju
Copy link
Member Author

johlju commented Jul 14, 2019

This can only be enabled or disabled per forest, so I don't see the need to an Ensure parameter. Ensure parameter is normally used when removing and adding objects. This is just a existing property that can only have two states, enabled or disabled. 🤔

@kungfoome
Copy link

Right, i forgot once it's enabled, you can no longer disable it. I guess just removing the shouldprocess would be sufficient enough.

@johlju
Copy link
Member Author

johlju commented Jul 14, 2019

Yes that is sufficient :) Are you working on this one now?

@kungfoome
Copy link

Maybe, I don't want to commit to it quite yet. I'll finish up a few things and see if I have time. It just depends on how long my other commitments take. For now, I'll keep it open for someone to grab if they wish.

@kungfoome
Copy link

Will wait until #330 is merged to work on this one.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 21, 2019
@johlju johlju self-assigned this Jul 21, 2019
@johlju
Copy link
Member Author

johlju commented Jul 21, 2019 •
edited
Loading

@kungfu71186 I will run with this one. I meant to do #329 but it was already fixed basically.

johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 21, 2019
@johlju
Changes to xActiveDirectory
0604804 
- Changes to xADObjectPermissionEntry
  - Remove remnants of the `SupportsShouldProcess` (issue dsccommunity#329).
- Changes to xADRecycleBin
  - Removed `SupportsShouldProcess` from the resource since DSC does not
    support that interactive function (issue dsccommunity#328).
@johlju johlju mentioned this issue Jul 21, 2019
Merged
9 tasks
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xActiveDirectory: Removing SupportsShouldProcess johlju/ActiveDirectoryDsc
2 participants
@kungfoome @johlju