Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Server 2016 forest functional level features #187

Closed
leegh123 opened this issue Mar 13, 2018 · 8 comments
Closed

Windows Server 2016 forest functional level features #187

leegh123 opened this issue Mar 13, 2018 · 8 comments
Labels
enhancement The issue is an enhancement request.

Comments

@leegh123
Copy link

when i config ad with dsc, how can i set the forest functional level features to windows server 2008 R2?

@leegh123 leegh123 reopened this Mar 13, 2018
@leegh123
Copy link
Author

i add DomainMode, ForestMode two parameters to the MSFT_xADDomain.psm1 file and change the MSFT_xADDomain.schema.mof too,now it is ok .

@johlju
Copy link
Member

johlju commented May 8, 2018

@leegh123 Can you describe what changes you did to the schema.mof?

@johlju johlju added the needs more information The issue needs more information from the author or the community. label May 8, 2018
@leegh123
Copy link
Author

leegh123 commented May 9, 2018

in the schema.mof file i add two lines
[Write, Description("set domain mode")] String DomainMode;
[Write, Description("Set Forest Mode")] String ForestMode;

@leegh123 leegh123 closed this as completed May 9, 2018
@joeyaiello joeyaiello removed the needs more information The issue needs more information from the author or the community. label May 9, 2018
@johlju
Copy link
Member

johlju commented May 9, 2018

@leegh123 Thanks for the information! Let's keep this issue open and I labeled it as an enhancement. Would you be interested in sending in a PR with this change?

I think we should use a [ValidateSet()] with the appropriate values the user can choose.

@johlju johlju reopened this May 9, 2018
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 9, 2018
@nyanhp
Copy link
Contributor

nyanhp commented Jun 7, 2018

Hi @johlju , I had the same problem at a customer of mine, extended the resource and quickly forgot about submitting the changes... Since there is no reaction from @leegh123 , I will go ahead and submit a pull request ~tomorrow after I have added some tests for the added functionality if that's ok.

@johlju
Copy link
Member

johlju commented Jun 7, 2018

@nyanhp Sounds great. Please send a PR.

johlju pushed a commit that referenced this issue Jun 18, 2018
- xADDomain is now capable of setting the forest and domain functional level (issue #187).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jun 18, 2018
@sakhatri-zz
Copy link

Do we have a timeline when to expect this feature to be available as a part of master branch?

@johlju
Copy link
Member

johlju commented Jul 13, 2018

@sakhatri nest community call is set for the 18th so approximately a week after that there will be new releases for resource modules in DSC Resource Kit.

johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
- xADDomain is now capable of setting the forest and domain functional level (issue dsccommunity#187).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

5 participants